Skip to content

Travel - Unable to book travel, an error occurred #55894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 8 tasks
lanitochka17 opened this issue Jan 28, 2025 · 20 comments
Closed
1 of 8 tasks

Travel - Unable to book travel, an error occurred #55894

lanitochka17 opened this issue Jan 28, 2025 · 20 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Jan 28, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.90-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #55300
Email or phone of affected tester (no customers): new expensifail account
Issue reported by: Applause - Internal Team
Component: Other

Action Performed:

Precondition: use new accounts: owner of a workspace and 1 or more admins, with logins from the same private domains that never used Travel before.

  1. ND: Sign in with one of the admins account
  2. OD: Sign in with one of the admins account and run script on workspace tab:
    NVP.set('travelSettings', {'testAccount': true});
  3. ND: Go to the Travel page and click the Book Travel button
  4. ND: Enter address
  5. ND: Accept the Terms and Conditions > click Continue

Expected Result:

Travel page is opened in a different tab

Actual Result:

An error 'Something went wrong'

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6726620_1738091465959.bandicam_2025-01-28_20-39-58-971.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Jan 28, 2025
Copy link

melvin-bot bot commented Jan 28, 2025

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@stitesExpensify
Copy link
Contributor

Hey @lanitochka17 can you please update any travel-related QA steps to use this script

var settings = NVP.get('travelSettings') || {};
settings.testAccount = true;
NVP.set('travelSettings', settings);

Instead of the current NVP.set('travelSettings', {'testAccount': true});?

@lanitochka17
Copy link
Author

@stitesExpensify ok

@stitesExpensify
Copy link
Contributor

Thank you! This should prevent accidental deletion of any existing travel data and prevent false-positives :)

@stitesExpensify
Copy link
Contributor

Soon this won't be a problem because we will set the entirety of @applause.expensifail.com to be a test domain

@trjExpensify
Copy link
Contributor

trjExpensify commented Jan 31, 2025

@stitesExpensify are you saying this bug is known, or asking for a retest from Applause after following those steps?

@stitesExpensify
Copy link
Contributor

Yes, I don't think we need to keep this open. Travel is definitely still working on both prod and staging

@IuliiaHerets
Copy link

QA team can repro this issue in the latest build (v9.1.18-3), used account [email protected]

58899-Web.mp4

@IuliiaHerets IuliiaHerets reopened this Mar 25, 2025
@trjExpensify
Copy link
Contributor

Soon this won't be a problem because we will set the entirety of @applause.expensifail.com to be a test domain

@stitesExpensify did we do this then?

@stitesExpensify
Copy link
Contributor

Yes, we did do that. I'll look into why this error happened

@stitesExpensify
Copy link
Contributor

'412 Can't provision Travel for the default workspace'

It looks like we asked the user to upgrade, created a new policy, and then didn't set it to be their default.

@stitesExpensify
Copy link
Contributor

cc @shubham1206agra since you worked on that feature

@melvin-bot melvin-bot bot added the Overdue label Mar 28, 2025
Copy link

melvin-bot bot commented Mar 31, 2025

@trjExpensify Eep! 4 days overdue now. Issues have feelings too...

@trjExpensify
Copy link
Contributor

Okay cool, @shubham1206agra can you take care of this one?

@melvin-bot melvin-bot bot removed the Overdue label Mar 31, 2025
@trjExpensify
Copy link
Contributor

Looks legit. Logs.

Request:

Bedrock\Client - Starting a request ~~ command: 'AcceptSpotnanaTerms' clusterName: 'auth' headers: '[authToken: '<REDACTED>' policyID: '2DE18B331326C23A' domainName: '' isInNewProvisioningBeta: '' idempotent: '' logParam: '[email protected]' urlToNewDot: 'https://staging.new.expensify.com/' shouldReadUsingThreads: '' shouldHandleOnyxUpdates: '1' isNewDotRequest: '1' clientUpdateID: '4582077851' maxNumberOfUpdates: '500' requestID: '92606d7fcb61020f-LAX' lastIP: '31.128.188.165' writeConsistency: 'ASYNC' priority: '500' timeout: '110000']'

That policyID:

Image

@shubham1206agra
Copy link
Contributor

@stitesExpensify Let's hold this issue for #57537.

@trjExpensify
Copy link
Contributor

Oh wow, that PR still isn't done? Commented.

@trjExpensify trjExpensify changed the title Travel - Unable to book travel, an error occurred [Hold PR #57537] Travel - Unable to book travel, an error occurred Mar 31, 2025
@trjExpensify
Copy link
Contributor

The PR we were held on was deployed last week. @shubham1206agra can you confirm that we can close this issue then?

@melvin-bot melvin-bot bot removed the Overdue label Apr 15, 2025
@trjExpensify trjExpensify changed the title [Hold PR #57537] Travel - Unable to book travel, an error occurred Travel - Unable to book travel, an error occurred Apr 15, 2025
@shubham1206agra
Copy link
Contributor

@trjExpensify Yes

@trjExpensify
Copy link
Contributor

Cool, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Weekly KSv2
Projects
Development

No branches or pull requests

5 participants