[Due for payment 2025-03-17] [$250] Loading indicator on the Inbox page has thinner line than on the Reports page

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.90-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Search

Action Performed:

1. Go to staging.new.expensify.com
2. Go offline.
3. Go to Account settings > Troubleshoot.
4. Click Clear cache and restart > Reset and refresh.
5. Compare the thickness of loading indicator in Inbox and Reports.

Expected Result:

The loading indicator in Inbox should have the same thickness as the one on the Reports page.

Actual Result:

The loading indicator in Inbox is thinner than on the Reports page.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6725831_1738045224757.20250128_141644.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021884250021913137171
• Upwork Job ID: 1884250021913137171
• Last Price Increase: 2025-03-11

Issue Owner

Current Issue Owner: @joekaufmanexpensify

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @Gonals (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[hungvu193]

Offending PR:
#52272

It came from this line:

App/src/styles/index.ts

Line 5365 in e411125

marginBottom: -1,

[trjExpensify]

@Expensify/design for eyes on what we want. I don't think it's a blocker really though, but should be a quick fix!

[Gonals]

Yep, I don't think we should block on this, so removing the label!

[dannymcclain]

Agree we don't need to block on this, but let's fix it! The reports version is actually the correct thickness. The inbox one looks too thin.

[trjExpensify]

Great, I've updated the OP and title to make it clear which one is wrong here.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021884250021913137171

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

[nkdengineer]

@getusha The PR is ready for review.

[joekaufmanexpensify]

PR in review.

[joekaufmanexpensify]

Same

[joekaufmanexpensify]

PR still in review, active discussion

[melvin-bot]

This issue has not been updated in over 15 days. @hungvu193, @srikarparsi, @joekaufmanexpensify eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[joekaufmanexpensify]

PR merged and on staging.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.10-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix loading indicator when the app is loading #56314

If no regressions arise, payment will be issued on 2025-03-17. 🎊

For reference, here are some details about the assignees on this issue:

• @hungvu193 requires payment through NewDot Manual Requests

[melvin-bot]

@hungvu193 @joekaufmanexpensify @hungvu193 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[getusha]

Handled as a regression, we can close this

[nkdengineer]

I think we should get the payment here, since in this PR we also fix other UI bugs like here that isn't related to the previous PR.

[getusha]

I think we should get the payment here, since in this PR we also fix other UI bugs like #56314 (comment) that isn't related to the previous PR.

Oh yes, forgot it's been a long ride addressing many issues. @joekaufmanexpensify what do you think?

[joekaufmanexpensify]

Got it. Was that one UI bug the only additional change handled in the PR, or was there anything else?

[nkdengineer]

Got it. Was that one UI bug the only additional change handled in the PR, or was there anything else?

@joekaufmanexpensify We also update the mobile search page with a 12px spacing between TopBar and the content to be consistent with other UI with the TopBar. That's all.

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @hungvu193 owed $250 via NewDot

BugZero Checklist (@joekaufmanexpensify)

• I have verified the correct assignees and roles are listed above and updated the necessary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1884250021913137171/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[joekaufmanexpensify]

@joekaufmanexpensify We also update the mobile search page with a 12px spacing between TopBar and the content to be consistent with other UI with the TopBar. That's all.

@nkdengineer @getusha thank you for confirming. I took a look at those two UI changes and it seems like they were quick CSS property changes. Is that right?

If so, while we appreciate you fitting those changes in, I don't think there was any material change in the scope or amount of work that was required to complete this PR, so I feel like additional payment wouldn't really make sense based on the added work.

[joekaufmanexpensify]

In the interim, I am going to close this as I don't think payment is needed here. Please let me know if you disagree or I am wrong about anything above and I am happy to raise this to the broader team for more discussion.