[Due for payment 2025-03-31] [$250] Wallet - Check Box is unselected when changing Account Type

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.89-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #54798
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Account settings > Wallet
3. Click Add bank account
4. Select any country other than US
5. Enter info and reach confirmation page
6. On confirmation page, Select the terms checkbox
7. Click the account type selector row
8. Change the account type and Confirm

Expected Result:

The checkbox should remain selected after changing account type

Actual Result:

The checkbox is unselected after changing account type

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6722248_1737672192939.Screen_Recording_2025-01-24_at_1.37.24_at_night.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021882570613169902798
• Upwork Job ID: 1882570613169902798
• Last Price Increase: 2025-01-30
• Automatic offers:
• dominictb | Reviewer | 106014247
• mkzie2 | Contributor | 106014248

Issue Owner

Current Issue Owner: @MitchExpensify

[melvin-bot]

Triggered auto assignment to @cead22 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

Different behavior on prod (bank account flow)

bandicam.2025-01-24.02-13-31-549.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021882570613169902798

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dominictb (External)

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The checkbox is unselected after changing account type

What is the root cause of that problem?

The confirmation step is unmounted when we go to the account type step. The account type step doesn't use FormProvider and when we merge the value we call setDraftValues which will merge the value to the draft form. While the value is merging, the confirmation step is rendered again, and in FormProvider, the draftValues is undefinfed the first time rendered (see the log below for more detail) then the acceptTerms is an empty string when we register the input.

App/src/pages/settings/Wallet/InternationalDepositAccount/substeps/AccountType.tsx

Line 34 in 4b8278b

setDraftValues(ONYXKEYS.FORMS.INTERNATIONAL_BANK_ACCOUNT_FORM, {[CONST.CORPAY_FIELDS.ACCOUNT_TYPE_KEY]: currentAccountType});

The reason it's an empty string instead of false is because we don't pass the valueType to InputWrapper then it's initialized as an empty string by getInitialValueByType function

App/src/components/Form/FormProvider.tsx

Line 294 in 4b8278b

inputValues[inputID] = inputProps.defaultValue ?? getInitialValueByType(inputProps.valueType);

What changes do you think we should make in order to solve the problem?

We have two options to fix this issue

1. We should only call onNext until the merge value is completed. We can return a promise in setDraftValues function and call the onNext in this promise

function setDraftValues(formID: OnyxFormKey, draftValues: NullishDeep<OnyxValue<OnyxFormDraftKey>>) {
    return Onyx.merge(`${formID}Draft`, draftValues ?? null);
}

setDraftValues(ONYXKEYS.FORMS.INTERNATIONAL_BANK_ACCOUNT_FORM, {[CONST.CORPAY_FIELDS.ACCOUNT_TYPE_KEY]: currentAccountType}).then(() => {
    onNext();
});

App/src/pages/settings/Wallet/InternationalDepositAccount/substeps/AccountType.tsx

Line 34 in 4b8278b

setDraftValues(ONYXKEYS.FORMS.INTERNATIONAL_BANK_ACCOUNT_FORM, {[CONST.CORPAY_FIELDS.ACCOUNT_TYPE_KEY]: currentAccountType});

2. Use FormProvider in AccountType step. That will require some migration. We can use the same way in TypeBusiness

Using defaultValue from formValues can work because formValues is passed from the InternationalDepositAccount that isn't unmounted in this flow. But I think it doesn't fix the RCA of this issue.

Optional: We can add valueType prop as boolean to the InputWrapper of the checkbox then this value can be initialized correctly.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@cead22, @dominictb Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@cead22, @dominictb Eep! 4 days overdue now. Issues have feelings too...

[cead22]

Waiting for proposal reviews

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[dominictb]

2. Use FormProvider in AccountType step. That will require some migration. We can use the same way in TypeBusiness

@mkzie2 provided correct RCA. Let's go with this solution to follow our form convention.

LGTM 🎀👀🎀

[melvin-bot]

Current assignee @cead22 is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @mkzie2 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

@cead22, @dominictb, @mkzie2 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mkzie2]

@dominictb The PR is ready for review.

[melvin-bot]

This issue has not been updated in over 15 days. @cead22, @dominictb, @mkzie2 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[dominictb]

PR is actively under review.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.17-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• migrate AccountType step to FormProvider #56464

If no regressions arise, payment will be issued on 2025-03-31. 🎊

For reference, here are some details about the assignees on this issue:

• @dominictb requires payment automatic offer (Reviewer)
• @mkzie2 requires payment automatic offer (Contributor)

[dominictb]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: NA

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: NA

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue: https://github.com/Expensify/Expensify/issues/486931

Regression Test Proposal

Precondition:

• Enable newDotInternationalDepositBankAccount beta

Test:

1. Go to Account settings > Wallet
2. Click Add bank account
3. Select any country other than US
4. Enter info and reach confirmation page
5. Verify in account type step, the Confirm button shows at the bottom
6. On confirmation page, Select the terms checkbox
7. Click the account type selector row
8. Verify in account type step, the Confirm button does NOT show at the bottom
9. Change the account type
10. Verify the terms checkbox remains selected

Do we agree 👍 or 👎

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @MitchExpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[MitchExpensify]

Payment summary:

• $250 @dominictb requires payment automatic offer (Reviewer)
• $250 @mkzie2 requires payment automatic offer (Contributor)

[MitchExpensify]

Paid and contracts ended