[HOLD for payment 2025-02-05] [HOLD for payment 2025-02-04] Self DM - User can submit track expense to self (You) again and send invoice to self

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.89-0
Reproducible in staging?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Money Requests

Action Performed:

Bug 1:

1. Go to staging.new.expensify.com
2. Go to self DM.
3. Submit an expense to the self DM.
4. Click Submit it to someone.
5. Select yourself under "Personal".
6. Submit the expense from yourself to yourself.

Bug 2:

1. Go to staging.new.expensify.com
2. Go to FAB > Send invoice.
3. Enter amount > Next.
4. Select the contact under "Personal", which is yourself.
5. Send the invoice.

Expected Result:

"Personal" section should not appear when submitting track expense to someone and sending invoice.

Actual Result:

"Personal" section appears when submitting track expense to someone and sending invoice, so user can submitting track expense to self and sending invoice to self.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/40cf9055-b8b0-4ef9-b20f-b4ad4b7cef44
https://github.com/user-attachments/assets/6f3e04f0-fbf2-4ef2-a5c3-d15499863706

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mananjadhav]

Unsure if this is a bug. We build a functionality to submit expense to yourself by adding a separate section Personal in the search list.

cc - @grgia @trjExpensify @JKobrynski

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Personal" section appears when submitting track expense to someone and sending invoice, so user can submitting track expense to self and sending invoice to self.

What is the root cause of that problem?

We are always getting the selfDM option here

App/src/pages/iou/request/MoneyRequestParticipantsSelector.tsx

Line 125 in aa849f1

includeSelfDM: true,

What changes do you think we should make in order to solve the problem?

We should only get the selfDM option if we're not moving the transaction from track expense and not sending invoice

const shouldIncludeSelfDM = !isMovingTransactionFromTrackExpense(action) && iouType !== CONST.IOU.TYPE.INVOICE;
includeSelfDM: shouldIncludeSelfDM,

App/src/pages/iou/request/MoneyRequestParticipantsSelector.tsx

Line 125 in aa849f1

includeSelfDM: true,

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[JKobrynski]

Hi, I'm Julian from Callstack - expert agency - and I'd like to work on this issue

[trjExpensify]

Treating this as a follow-up to #55016

To confirm the expectation:

• The selfDM isn't an option on the choose receipt page in the Send invoice flow
• The selfDM isn't an option on the choose receipt page in the Submit it to someone flow.

[JKobrynski]

Update:

The PR is ready for review!

[grgia]

PR was merged

[mountiny]

Asked QA for a test of the CP

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.89-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix - Self DM - User can submit track expense to self (You) again and send invoice to self AND fix smartscan share in oldDot #55716

If no regressions arise, payment will be issued on 2025-02-04. 🎊

For reference, here are some details about the assignees on this issue:

• @mananjadhav requires payment through NewDot Manual Requests
• @JKobrynski does not require payment (Contractor)

[melvin-bot]

@mananjadhav @trjExpensify @mananjadhav The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.90-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix - Self DM - User can submit track expense to self (You) again and send invoice to self AND fix smartscan share in oldDot #55716

If no regressions arise, payment will be issued on 2025-02-05. 🎊

For reference, here are some details about the assignees on this issue:

• @mananjadhav requires payment through NewDot Manual Requests
• @JKobrynski does not require payment (Contractor)

[melvin-bot]

@mananjadhav @trjExpensify @mananjadhav The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[mananjadhav]

While this is a follow up to the PR I don't think this should treated as a regression or have any payout for the linked PR. It should be included in the scope of the original PR.

cc - @trjExpensify @grgia

[trjExpensify]

Yep, makes sense to me. I'll just close this.