[HOLD for payment 2025-02-05] [HOLD for payment 2025-02-04] [$250] Report - Chat is partially scrolled down when returning from expense thread

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.89-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Chat Report View

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Send enough messages so that the chat is scrollable.
4. Submit an expense to the workspace chat.
5. Click on the expense preview.
6. Click on the header subtitle to return to main chat.
7. Note that the chat is only partially scrolled down and only shows half the expense preview.
8. Scroll down to the bottom.
9. Click on the same workspace chat on LHN.

Expected Result:

In Step 7, the chat will scroll down and display the expense preview completely.
In Step 9, when clicking on the same workspace chat on LHN, the report will not "jump".

Actual Result:

In Step 7, the chat is only partially scrolled down and only shows half the expense preview.
In Step 9, when clicking on the same workspace chat on LHN, the report "jumps".

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021882505248719036279
• Upwork Job ID: 1882505248719036279
• Last Price Increase: 2025-01-23

Issue Owner

Current Issue Owner: @lschurr

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @neil-marcellini (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[vincdargento]

@lschurr FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021882505248719036279

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

[neil-marcellini]

I found two PRs in the last staging deploy which I think may have caused the issue.

Sending a message scrolls down to previous message
Fix new messages indicator after comment linking

I will test on production to double check that it's a real blocker. Then I will test on dev main to make sure I can reproduce the issue. Then I will revert each PR and see if it's fixed.

[neil-marcellini]

Yep, the bug is not present on prod

prod-scoll-2025-01-23_11-14-46.mp4

I can reproduce on dev main

dev-scroll-2025-01-23_11-18-30.mp4

After reverting Sending a message scrolls down to previous message. It's not fixed.

revert-54071-2025-01-23_11-24-55.mp4

After reverting Fix new messages indicator after comment linking, it's not fixed.

revert-55582-2025-01-23_11-27-15.mp4

Last attempt, reverting both. Still not fixed. I'll start debugging now. It's also possible I didn't revert that first PR correctly since there were conflicts, so I'll try to understand both PRs.

[neil-marcellini]

Here are the results of git bisect. I'll see what the best way to revert is.

App (cc54548f32c) git bisect good
cf9b7e4e194660a50cb7ffc3cf676471d895f175 is the first bad commit
commit cf9b7e4e194660a50cb7ffc3cf676471d895f175
Author: Adam Horodyski <[email protected]>
Date:   Fri Jan 17 17:48:41 2025 +0100

    chore: refactor to rely on existing map of report transactions from report utils

 src/components/MoneyReportHeader.tsx           | 27 +++++++------
 .../ReportActionItem/ReportPreview.tsx         | 29 +++++++-------
 src/libs/IOUUtils.ts                           |  5 ++-
 src/libs/ReportUtils.ts                        | 17 +++++++--
 src/libs/TransactionUtils/index.ts             | 38 ++-----------------
 src/libs/actions/IOU.ts                        |  6 +--
 src/libs/actions/Policy/Policy.ts              |  3 +-
 .../TransactionBackupsToCollection.ts          |  2 +-
 src/pages/ReportDetailsPage.tsx                | 12 +++---
 9 files changed, 63 insertions(+), 76 deletions(-)
➜  App (cc54548f32c) 

[neil-marcellini]

That bad commit comes from this PR perf: create report -> transactions map to optimize performance. I reverted locally and verified that fixes the issue. I will put up the revert PR now. I might have to make modifications to get lint passing. I'll also ask the team if we want to revert or not, since this bug is annoying but not the worst.

[neil-marcellini]

Follow along in Slack here

[TMisiukiewicz]

Hey, Tomasz from Callstack here, I'll fix it to avoid full revert 🙏

[Beamanator]

Thanks @TMisiukiewicz 👍 do you have a draft PR where you're working on the fix?

[TMisiukiewicz]

@Beamanator PR open: #55712

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[Beamanator]

Thanks! Looking great!

[Beamanator]

#55712 was checked off the deploy checklist by QA, so this seems to have been fixed!!

[neil-marcellini]

All done

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.89-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix: partial scroll when returning from expense thread #55712

If no regressions arise, payment will be issued on 2025-02-04. 🎊

For reference, here are some details about the assignees on this issue:

• @suneox requires payment (Needs manual offer from BZ)

[melvin-bot]

@suneox @lschurr @suneox The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.90-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix: partial scroll when returning from expense thread #55712

If no regressions arise, payment will be issued on 2025-02-05. 🎊

For reference, here are some details about the assignees on this issue:

• @suneox requires payment (Needs manual offer from BZ)

[melvin-bot]

@suneox @lschurr @suneox The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]