[HOLD for payment 2024-12-25] [HOLD for payment 2024-12-20] [$250] Search - Individual expenses displays "Submit"/"Approve" button when the expenses are grouped

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.75-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Search

Action Performed:

Precondition:

• Delayed submission is enabled.
• Add approvals is enabled.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit two expenses to the workspace chat.
4. Go to Search > Draft.
5. Click Submit button on the individual expense (not the button next to report title).
6. Click the Submit button next to report title.
7. Click Approve button on the individual expense.

Expected Result:

There should be only one "Submit/Approve" button on the group expenses.
The individual expenses should display "view" button under the report title (production behavior).

Actual Result:

The individual expenses display "Submit"/"Approve" button when the expenses are grouped expenses.
Clicking on the buttonon the individual expense opens expense RHP instead of submitting/approving.

The same issue also happens with "Pay" button.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6691703_1733969916446.20241212_101411.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021867228840223993009
• Upwork Job ID: 1867228840223993009
• Last Price Increase: 2024-12-12
• Automatic offers:
• ishpaul777 | Reviewer | 105308742

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @sonialiap

[melvin-bot]

Triggered auto assignment to @mountiny (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

Production has a different behavior

Screen.Recording.2024-12-12.at.10.41.57.AM.mov

[mountiny]

cc @lakchote @luacmartins @ishpaul777 seems like this is coming from here #53641

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021867228840223993009

[melvin-bot]

Current assignee @ishpaul777 is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[luacmartins]

I can take this one

[mountiny]

The PR is being reviewed by a C+

[mountiny]

PR reverted, we can close once checked in staging

[luacmartins]

Fixed in staging

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.75-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Fix pay button after deleting expense" #54042

If no regressions arise, payment will be issued on 2024-12-20. 🎊

For reference, here are some details about the assignees on this issue:

• @c3024 requires payment through NewDot Manual Requests
• @ishpaul777 requires payment automatic offer (Reviewer)

[melvin-bot]

@c3024 / @ishpaul777 @sonialiap @c3024 / @ishpaul777 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.76-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Fix pay button after deleting expense" #54042

If no regressions arise, payment will be issued on 2024-12-25. 🎊

For reference, here are some details about the assignees on this issue:

• @c3024 requires payment through NewDot Manual Requests
• @ishpaul777 requires payment automatic offer (Reviewer)

[melvin-bot]

@c3024 / @ishpaul777 @sonialiap @c3024 / @ishpaul777 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]