[$500] [Due for payment 2025-02-13] [Add onboarding for new workspaces being created] Create new setup tasks when users create a workspace

[francoisl]

Part of the project "Adding onboarding for new workspaces being created"

Main issue: #48591
Doc section: https://docs.google.com/document/d/19u6ZQbNuF-v5oovIkQlmwYV4SXeAgey50pymsj5QHRY/edit?tab=t.0#heading=h.vwt3yefp8jmh (External only)

Feature Description

When a user who didn't choose the option "Manage my team's expenses" during the initial onboarding eventually creates a workspace, create onboarding tasks to teach them what to do next.

Implementation steps

1. Prep work:

   1. Add new constant newDotTrackWorkspace to backendOnboardingChoices - Design doc section
   2. Extract the logic to generate the request and optimistic data for onboarding tasks out of completeOnboarding(), for clarity and reusability – Design doc section

2. Create new setup tasks when users create a workspace

   • Design doc section ('External' section only)
   • Update CategorizeTrackedExpense, ShareTrackedExpense, and CreateWorkspace to generate and pass the new onboarding task data to the API if the user doesn't already have a createWorkspace onboarding task

Issue Owner

Current Issue Owner: @francoisl

[francoisl]

(Keeping internal because we're going to work with a C+ on this)

[mananjadhav]

Reviewed the design document. Will take another pass to see if there are any gaps. Will start with the implementation by tomorrow.

[mananjadhav]

@francoisl Is there anything pushed on the backend to start this?

[francoisl]

One part is deployed, another one won't be until at least tomorrow, and the tasks won't be saved until both parts are.

For now, the part 1 "Prep work" I described above shouldn't require any backend changes. Also, for step 2 we can start saving the task data in the optimistic data of the API request, and test it offline?

[francoisl]

@mananjadhav the backend changes for passing guidedSetupData and engagementChoice to the API commands CategorizeTrackedExpense, ShareTrackedExpense, and CreateWorkspace are now live. Let me know if anything is not working as expected.

[mananjadhav]

Okay thanks. I'll check those and reach out to you if any questions.

[mananjadhav]

Started with this, the PR will be up by tomorrow.

[melvin-bot]

@francoisl, @mananjadhav Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mananjadhav]

I was out sick yesterday. I am half done, will finish this by weekend.

[anmurali]

@mananjadhav - do you have an update on this PR?

[melvin-bot]

@francoisl, @mananjadhav Huh... This is 4 days overdue. Who can take care of this?

[mananjadhav]

Apologies I was unwell. I am just getting back and will have this ready in 1-2 days.

[danielrvidal]

Thank you @mananjadhav, let us know if you need anything from our side!

[melvin-bot]

@francoisl, @mananjadhav Eep! 4 days overdue now. Issues have feelings too...

[mananjadhav]

PR work in progress. Will be raising the draft today.

[francoisl]

Sounds good, feel free to send it my way even if it's not fully ready, I can start taking a look and testing.

[melvin-bot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[francoisl]

@mallenexpensify FYI I increased the payout since this was a little bigger than a regular bug fix / task.

[melvin-bot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[mallenexpensify]

@ishpaul777 can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~021890561801107228170

I see @mananjadhav assigned but I don't see a full review on the PR so I'm assuming payment isn't due to them. Comment if ya disagree.

[mananjadhav]

@mallenexpensify The original PR was reviewed by me. But due to the #55302 (comment) we had to redo the PR. The new duplicate PR was merged where you won't see my review. Hence I am eligible for the payout.

[francoisl]

Yes that's correct ^. We had to revert the original PR due to some unrelated issues with bad commits being on the main branch, and then make the second identical PR. I directly approved and merged that second PR since it was the same as the first PR, which had already been reviewed and tested.

[ishpaul777]

thank you @mallenexpensify, I have accepted offer!

[mallenexpensify]

Contributor: @ishpaul777 paid $500 via Upwork
Contributor+: @mananjadhav due $500 via NewDot

Where are we at with the need for a regression test here? We don't have Bug or New Feature so a checklist wasn't auto-populated.

[garrettmknight]

$500 approved for @mananjadhav

[mananjadhav]

Considering this is a new feature does the checklist apply? and with regards to the regression test, would it already exist as a part of the feature design? If not I'll create one but I think in my previous projects experience, I've seen it exists for the new features.

[mallenexpensify]

We def want regression tests for new features, sometimes they're created all at once as part of a project and sometimes they're done per feature. @francoisl do you know how we want to handle here? Thx

[melvin-bot]

@francoisl, @mananjadhav, @mallenexpensify, @ishpaul777 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mananjadhav]

Quick bump @francoisl

[francoisl]

I opened an internal issue to create the regression tests
https://github.com/Expensify/Expensify/issues/474370

[francoisl]

@mallenexpensify as far as I can tell, we just need to issue the payments and close this?

[parasharrajat]

Looks like PR of this isue caused an issue #57499

[ishpaul777]

not denying, but can you help me understand reason for your suspicion @parasharrajat also I am not able to reproduce the issue

[parasharrajat]

Try to fail the workspace creation with an error, and it will create that issue. I checked the onyx keys that affect that UI state and all of them were present in the failure state.

It might be backend but if you can give it a try and confirm this, it would be great.

[mallenexpensify]

Going to wait a min for payment, pending potential regression. Note to self to check the regression timeline/window too.

[ishpaul777]

I tried to simulate as shown in video of issue but I could not get such error when using Troubleshoot -> Simulate failing network requests

[mananjadhav]

I cannot reproduce it either.

Going to wait a min for payment, pending potential regression. Note to self to check the regression timeline/window too.

@mallenexpensify This issue was supposed to be closed by Feb 13 and I think it's already paid out. I think we should close this issue and discuss in the linked issue.