Skip to content

[$250] Web - Public Room - The conversation does not load in real-time #53139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 of 8 tasks
lanitochka17 opened this issue Nov 26, 2024 · 49 comments
Open
1 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Nov 26, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.66-8
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5174789&group_by=cases:section_id&group_order=asc&group_id=229066
Email or phone of affected tester (no customers): [email protected], [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

Setup - Secondary device

  1. iPhone 12 iOS 18.1 - Login and navigate to this link https://staging.new.expensify.com/r/2091104345528462
    Steps:
  2. Log out of New Expensify
  3. Navigate to this link as anon user- https://staging.new.expensify.com/r/2091104345528462
  4. Keep a view of the conversation in the main testing device
  5. As the secondary user - Send some messages in the public room
  6. Verify the messages are displayed in real-time as the anon user
  7. As the secondary user - Send an attachment
  8. Verify the attachment is displayed in real-time as the anon user
  9. Click on the attachment as the anon user
  10. Verify the anon user can view the attachment
  11. As the secondary user - Delete a message
  12. Verify the message is deleted in real-time for the anon user
  13. As the secondary user - Edit a message
  14. Verify the message is edited in real-time for the anon user
  15. As the secondary user - React to a message
  16. Verify the message displays the reaction in real-time for the anon user
  17. Navigate to a thread
  18. Verify the anon user can view the thread

Expected Result:

Anon users should be able to see real-time actions like, send, edit, react, and delete messages made in the public room.
Anon users should be able to view attachments and threads.

Actual Result:

The real-time conversation in the public room does not update immediately when a user sends a message, an attachment, deletes, or reacts to a message. The user must refresh the page to view the latest changes.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6654226_1730721726212.RealtimeiOS18.1.mp4
Bug6654226_1730721726235.RealtimePublic.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021864696834836429253
  • Upwork Job ID: 1864696834836429253
  • Last Price Increase: 2025-01-02
Issue OwnerCurrent Issue Owner: @aldo-expensify
@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 26, 2024
Copy link

melvin-bot bot commented Nov 26, 2024

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Overdue label Nov 29, 2024
Copy link

melvin-bot bot commented Dec 2, 2024

@puneetlath Huh... This is 4 days overdue. Who can take care of this?

Copy link

melvin-bot bot commented Dec 4, 2024

@puneetlath Still overdue 6 days?! Let's take care of this!

@puneetlath
Copy link
Contributor

I was able to confirm the issue. Not sure if it's front-end or back-end. Going to start external and see where that gets us.

@melvin-bot melvin-bot bot removed the Overdue label Dec 5, 2024
@puneetlath puneetlath added External Added to denote the issue can be worked on by a contributor Overdue labels Dec 5, 2024
@melvin-bot melvin-bot bot changed the title Web - Public Room - The conversation does not load in real-time [$250] Web - Public Room - The conversation does not load in real-time Dec 5, 2024
Copy link

melvin-bot bot commented Dec 5, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021864696834836429253

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 5, 2024
Copy link

melvin-bot bot commented Dec 5, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

@melvin-bot melvin-bot bot removed the Overdue label Dec 5, 2024
@angemollou
Copy link

Hello @puneetlath @fedirjh,

Solution #1
Whenever another user is typing you can see "X is typing...".
I guess this is the same approach/mechanism which syncs messages too.
So, one can sync messages the same way "X is typing..." Effect Hook does.

Solution #2
What event is triggered when we switch room (inbox)? Triggering this event will display the buffered hidden messages.
That means we don't have to refresh the page to sync messages.
So messages are synced in background by hidden. Text/message component isn't appended to the DOM.
So this isn't a backend issue but a frontend one.

Btw, the issuse also concerned MacOS: Firefox.

Copy link

melvin-bot bot commented Dec 5, 2024

📣 @angemollou! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@angemollou
Copy link

angemollou commented Dec 5, 2024

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~0155562fb4d538d083

Hello @puneetlath @fedirjh,

Solution 1

Whenever another user is typing you can see "X is typing...".
I guess this is the same approach/mechanism which syncs messages too.
So, one can sync messages the same way "X is typing..." Effect Hook does.

Solution 2

What event is triggered when we switch room (inbox)? Triggering this event will display the buffered hidden messages.
That means we don't have to refresh the page to sync messages.
So messages are synced in background by hidden. Text/message component isn't appended to the DOM.
So this isn't a backend issue but a frontend one.

Btw, the issuse also concerned MacOS: Firefox.

Copy link

melvin-bot bot commented Dec 5, 2024

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

Copy link

melvin-bot bot commented Dec 9, 2024

@puneetlath, @fedirjh Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Dec 9, 2024
@fedirjh
Copy link
Contributor

fedirjh commented Dec 9, 2024

Awaiting on proposals

@melvin-bot melvin-bot bot removed the Overdue label Dec 9, 2024
Copy link

melvin-bot bot commented Dec 10, 2024

@puneetlath @fedirjh this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Copy link

melvin-bot bot commented Dec 12, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Dec 12, 2024
Copy link

melvin-bot bot commented Dec 13, 2024

@puneetlath, @fedirjh Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@fedirjh
Copy link
Contributor

fedirjh commented Dec 13, 2024

Awaiting on proposals

@zirgulis
Copy link
Contributor

zirgulis commented Jan 29, 2025

this is a BE issue. The message events from pusher come to FE ~3mins later. Doesn't matter if user is logged in or anonymous, the behaviour is the same (for the public room mentioned in the ticket).

@muttmuure muttmuure moved this from CRITICAL to MEDIUM in [#whatsnext] #quality Feb 4, 2025
@melvin-bot melvin-bot bot added the Overdue label Feb 6, 2025
@aldo-expensify
Copy link
Contributor

I haven't had time to get back to this, I'll try later during the week

@melvin-bot melvin-bot bot removed the Overdue label Feb 19, 2025
@melvin-bot melvin-bot bot added the Overdue label Feb 27, 2025
@aldo-expensify
Copy link
Contributor

aldo-expensify commented Feb 28, 2025

I think this is very related to what I'm investigating here: https://github.com/Expensify/Expensify/issues/473841#issuecomment-2688374701

In summary: Adding a comment AddComment always pushes all participants' notificationPreferences to everyone in the report. If the report has thousands of accounts, this sometimes is just extremely slow to push or sometimes it causes "out of memory" error in the backend and the update is not pushed.

I'll try to:

  1. Change the frontend so the notificationPreference defaults to always for rooms like #announce if it is missing (have to investigate what is the right default for a public room)
  2. Stop pushing the default values from the backend

To keep the scope small, I'll focus on the #announce room and custom public rooms first, which are usually the biggest.

@melvin-bot melvin-bot bot removed the Overdue label Feb 28, 2025
@melvin-bot melvin-bot bot added the Overdue label Mar 10, 2025
@aldo-expensify
Copy link
Contributor

PR was merged, waiting for deploy: https://github.com/Expensify/Auth/pull/14403

@melvin-bot melvin-bot bot removed the Overdue label Mar 12, 2025
@mallenexpensify mallenexpensify moved this from MEDIUM to LOW in [#whatsnext] #quality Mar 12, 2025
@melvin-bot melvin-bot bot added the Overdue label Mar 20, 2025
@aldo-expensify
Copy link
Contributor

Posted a message in the public room 2091104345528462, and after a few minutes it showed up for my other account. I can see that the job took a long time because of the amount of accounts the participants update had to be pushed to:

https://www.expensify.com/_devportal/tools/logSearch/#query=request_id:(%22Ypk2NO%22)+AND+timestamp:[2025-03-22T01:09:09.870Z+TO+2025-03-22T03:09:09.870Z]&index=logs_expensify-033059

@melvin-bot melvin-bot bot removed the Overdue label Mar 22, 2025
@aldo-expensify
Copy link
Contributor

I wonder if we could do something like: excluded anon accounts that have not have any activity in a long time... or just remove them from the room.

@melvin-bot melvin-bot bot added the Overdue label Mar 31, 2025
@aldo-expensify
Copy link
Contributor

aldo-expensify commented Apr 2, 2025

I haven't have time for this, and I don't think I'll have before the end up the week. Next week I'll be OOO for two weeks, so maybe we should reassign if we want to see some progress on this soon.

Offering to pass this on: https://expensify.slack.com/archives/C03TQ48KC/p1743560528177969

@melvin-bot melvin-bot bot removed the Overdue label Apr 2, 2025
@aldo-expensify
Copy link
Contributor

I'm going to un-assign myself from this since I'm going OOO so it is clear that no one is working on it.

@aldo-expensify aldo-expensify removed their assignment Apr 4, 2025
@melvin-bot melvin-bot bot added the Overdue label Apr 14, 2025
@VictoriaExpensify
Copy link
Contributor

Not OD, waiting for an engineer to pick it up

@melvin-bot melvin-bot bot removed the Overdue label Apr 24, 2025
@melvin-bot melvin-bot bot added the Overdue label May 2, 2025
@VictoriaExpensify
Copy link
Contributor

@aldo-expensify I think you're back from leave now so I'm going to re-assign you since this hasn't been picked up

@melvin-bot melvin-bot bot removed the Overdue label May 15, 2025
@melvin-bot melvin-bot bot removed the Hot Pick Ready for an engineer to pick up and run with label May 15, 2025
@aldo-expensify
Copy link
Contributor

Yes, I'm back, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
Status: LOW
Development

No branches or pull requests

8 participants