Attendee tracking feature should be a sub-category of 'Rules'

[Julesssss]

A part of collect v2

Summary of changes

• Make attendee tracking a feature that can be enabled/disabled via a toggle
• Make it restricted to Control policies, by placing the toggle in the Rules section of the workspace editor (which can only be accessed after upgrading)

Initial discussion here (internal).

Technical changes

1. Backend

   • Create a new API command SetPolicyAttendeeTrackingEnabled that takes a policyID: string and enabled: boolean
   • Set the enabled state of the feature as a new policy attribute isAttendeeTrackingEnabled
   • https://github.com/Expensify/Expensify/issues/504051

2. Frontend

   • Update onyx/Policy.ts with a new prop isAttendeeTrackingEnabled?: boolean
   • Add a toggle to enable or disable Attendee Tracking in the Rules section of the workspace editor, under the existing eReceipts toggle
     • For backwards compatibility, assume the feature is disabled if the prop isAttendeeTrackingEnabled doesn't exist
     • Use the new API command SetPolicyAttendeeTrackingEnabled when toggling the option, with optimistic data
   • Update shouldShowAttendees to only show the attendee selector when the feature is enabled on the selected workspace

3. Backend (can be done as follow-up updates)

   1. Update commands to throw an error if trying to set/edit attendees on a collect policy expense
   2. Disable the flag after downgrading a policy
   3. Prevent from enabling the feature on collect policies

[dylanexpensify]

@Julesssss assigning you for this for now, but feel free to assign someone else if need be!

[Julesssss]

Project is held

[Julesssss]

Project remains held

[melvin-bot]

@Julesssss, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

[Julesssss]

FYI @francoisl.

Perhaps you've already handled this elsewhere but there was a request to change where the attendee feature switch lives.

[francoisl]

I don't think it's even a feature you can disable at the moment, right? I also don't see any mention of this in the design doc, but it sounds like it's something we can do as a follow-up once all the main functionality is ironed out.

[Julesssss]

Yeah this came later and wasn't added to the doc. I don't think the feature has a toggle in the settings, but if I recall correctly there was a high level toggle under categories with that disabled it. That could be outdated though 😬 I have no idea

[francoisl]

Updated the OP above, going to reprioritize to finish this before EOM.

[melvin-bot]

Triggered auto assignment to @isabelastisser (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[francoisl]

@allroundexperts is this something you're interested in working on as a follow-up improvement task?

[allroundexperts]

Sure thing. Can I get assigned, please?

[JmillsExpensify]

Done

[allroundexperts]

@francoisl Is the command SetPolicyAttendeeTrackingEnabled ready?

[francoisl]

No, I'm finishing it up today, it should be available on staging early next week. I'll let you know when!

[allroundexperts]

In the OP, @francoisl Can you also specify what the error field would be called?

[allroundexperts]

Draft PR ready: #62684