Skip to content

[Wave Control] [QBD] [Export] Export Expensify card transactions #49713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lakchote opened this issue Sep 25, 2024 · 2 comments
Closed

[Wave Control] [QBD] [Export] Export Expensify card transactions #49713

lakchote opened this issue Sep 25, 2024 · 2 comments
Assignees
@hoangzinh @lakchote @ZhenjaHorbach
Labels
Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@lakchote
Copy link
Contributor

Will be worked on by an external contributor (see https://expensify.slack.com/archives/C03SLTAEULW/p1726876645021139).

Design doc link: https://docs.google.com/document/d/1LQNlTBlHjFqRdru_4UkqVr0QRseNNDq2IhFFpXcgfwY/edit#bookmark=id.vn9ay1xc1ktu
@lakchote lakchote self-assigned this Sep 25, 2024
@melvin-bot melvin-bot bot added the Overdue label Oct 3, 2024
@lakchote
Copy link
Contributor Author

lakchote commented Oct 7, 2024

Still on hold for #49697.

@melvin-bot melvin-bot bot removed the Overdue label Oct 7, 2024
@lakchote lakchote changed the title [HOLD #49697] [Wave Control] [QBD] [Export] Export Expensify card transactions [Wave Control] [QBD] [Export] Export Expensify card transactions Oct 15, 2024
@lakchote lakchote added the Reviewing Has a PR in review label Oct 15, 2024
@lakchote
Copy link
Contributor Author

Has been done by the PR #50164

See in details:

App/src/pages/workspace/accounting/qbd/export/QuickbooksDesktopExportPage.tsx

Lines 67 to 72 in ed82b19

{
description: translate('workspace.qbd.exportExpensifyCard'),
title: translate(`workspace.qbd.accounts.${CONST.QUICKBOOKS_DESKTOP_NON_REIMBURSABLE_EXPORT_ACCOUNT_TYPE.CREDIT_CARD}`),
shouldShowRightIcon: false,
interactive: false,
},

@lakchote lakchote moved this to Release 3: Fall 2024 (Nov) in #expensify-bugs Oct 15, 2024
@github-project-automation github-project-automation bot moved this from Release 3: Fall 2024 (Nov) to Done in #expensify-bugs Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hoangzinh hoangzinh

@lakchote lakchote

@ZhenjaHorbach ZhenjaHorbach

Labels
Engineering Reviewing Has a PR in review Weekly KSv2
Projects
#expensify-bugs
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hoangzinh @lakchote @ZhenjaHorbach