Skip to content

[$250] [HOLD for payment 2024-10-29] [Wave Control] [QBD] [Export] Export company cards page #49712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lakchote opened this issue Sep 25, 2024 · 16 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.

Comments

@lakchote
Copy link
Contributor

lakchote commented Sep 25, 2024

Will be worked on by an external contributor (see https://expensify.slack.com/archives/C03SLTAEULW/p1726876645021139).

Design doc link: https://docs.google.com/document/d/1LQNlTBlHjFqRdru_4UkqVr0QRseNNDq2IhFFpXcgfwY/edit#bookmark=id.kfrue4ocoskh

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021852429635473360370
  • Upwork Job ID: 1852429635473360370
  • Last Price Increase: 2024-11-01
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @mallenexpensify
@lakchote lakchote self-assigned this Sep 25, 2024
@lakchote lakchote moved this to Release 3: Fall 2024 (Nov) in #expensify-bugs Sep 25, 2024
@melvin-bot melvin-bot bot added the Overdue label Oct 3, 2024
@lakchote
Copy link
Contributor Author

lakchote commented Oct 7, 2024

Still on hold for #49697.

@melvin-bot melvin-bot bot removed the Overdue label Oct 7, 2024
@lakchote lakchote changed the title [HOLD #49697] [Wave Control] [QBD] [Export] Export company cards page [Wave Control] [QBD] [Export] Export company cards page Oct 15, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 15, 2024
@melvin-bot melvin-bot bot changed the title [Wave Control] [QBD] [Export] Export company cards page [HOLD for payment 2024-10-29] [Wave Control] [QBD] [Export] Export company cards page Oct 22, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 22, 2024
Copy link

melvin-bot bot commented Oct 22, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Oct 22, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.51-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-10-29. 🎊

For reference, here are some details about the assignees on this issue:

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 28, 2024
@lakchote lakchote added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 29, 2024
Copy link

melvin-bot bot commented Oct 29, 2024

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@lakchote lakchote removed the Bug Something is broken. Auto assigns a BugZero manager. label Oct 29, 2024
Copy link

melvin-bot bot commented Oct 29, 2024

Payment Summary

Upwork Job

BugZero Checklist (@mallenexpensify)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@hoangzinh
Copy link
Contributor

Regression Test Proposal

Prerequisites:

  • Turn on Beta quickbooksDesktopOnNewDot on your account
  • Connect your workspace to QBD
  1. Sign-in on the account above
  2. Go to the connected QBD Workspace -> Accounting
  3. Click on Export menu under QuickBooks Desktop connection
  4. Click on Export company card expenses as menu item
  5. Click on Export as menu item
  6. Verify that there is a list of export types
  7. Select Credit cards option
  8. Verify that it goes back to Export company card expenses as page and it shows Credit card account menu item
  9. Click on Credit card account menu item
  10. Verify it shows a list of credit card accounts
  11. Select one
  12. Verify that it's selected successfully
  13. Do step 5 again
  14. Select Check option
  15. Verify that it goes back to Export company card expenses as page and it shows Bank account menu item
  16. Click on Bank account menu item
  17. Verify it shows a list of bank accounts
  18. Repeat steps 11-13
  19. Select Vendor bill option
  20. Verify that it goes back to Export company card expenses as page and it shows Account payable menu item and Default vendor toggle button
  21. Click on Account payable menu item
  22. Verify it shows a list of account payable
  23. Repeat steps 11-12
  24. Turn on the Default vendor toggle button
  25. Verify it displays an additional Default vendor menu item
  26. Click on Default vendor menu item
  27. Verify that there is a list of vendors and after selecting one of them, it becomes the current

Do we agree 👍 or 👎

@mallenexpensify mallenexpensify added the NewFeature Something to build that is a new item. label Nov 1, 2024
@melvin-bot melvin-bot bot added the Overdue label Nov 1, 2024
Copy link

melvin-bot bot commented Nov 1, 2024

Current assignee @mallenexpensify is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 Overdue labels Nov 1, 2024
@mallenexpensify mallenexpensify added the External Added to denote the issue can be worked on by a contributor label Nov 1, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-10-29] [Wave Control] [QBD] [Export] Export company cards page [$250] [HOLD for payment 2024-10-29] [Wave Control] [QBD] [Export] Export company cards page Nov 1, 2024
Copy link

melvin-bot bot commented Nov 1, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021852429635473360370

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 1, 2024
Copy link

melvin-bot bot commented Nov 1, 2024

Current assignees @hoangzinh and @ZhenjaHorbach are eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Nov 1, 2024
@mallenexpensify
Copy link
Contributor

@hoangzinh @ZhenjaHorbach , can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~021852429635473360370

Test case (with the longest list of steps I've seen!) created

@mallenexpensify mallenexpensify removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 1, 2024
@hoangzinh
Copy link
Contributor

Accepted. Thanks @mallenexpensify

@ZhenjaHorbach
Copy link
Contributor

ZhenjaHorbach commented Nov 3, 2024

@hoangzinh @ZhenjaHorbach , can you please accept the job and reply here once you have? https://www.upwork.com/jobs/~021852429635473360370

Test case (with the longest list of steps I've seen!) created

Done
Thanks !

@melvin-bot melvin-bot bot added the Overdue label Nov 4, 2024
@lakchote
Copy link
Contributor Author

lakchote commented Nov 4, 2024

Not overdue. @hoangzinh and @ZhenjaHorbach have accepted the job from Upwork.

@mallenexpensify
Copy link
Contributor

Contributor: @ZhenjaHorbach paid $250 via Upwork
Contributor+: @hoangzinh paid $250 via Upwork.

Thanks!

@melvin-bot melvin-bot bot removed the Overdue label Nov 5, 2024
@github-project-automation github-project-automation bot moved this from Release 3: Fall 2024 (Nov) to Done in #expensify-bugs Nov 5, 2024
Copy link

melvin-bot bot commented Nov 5, 2024

@lakchote @mallenexpensify Be sure to fill out the Contact List!

@garrettmknight
Copy link
Contributor

$250 approved for @hoangzinh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Projects
Archived in project
Development

No branches or pull requests

5 participants