Chat - No tool tip for download icon for docx file

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue was found when executing #4661

Action Performed:

1. Launch App and login
2. Send any docx file
3. Hover mouse to download sign

Expected Result:

The tooltip should be appeared

Actual Result:

No tooltips for download icon.

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• Desktop App

Version Number:
1.0.88-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:

Bug5211202_Download_tooltip.mp4

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @pecanoro (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[kakajann]

Proposal

Change this

App/src/components/AttachmentView.js

Lines 65 to 69 in ae38f1b

	{props.shouldShowDownloadIcon && (
	<View style={styles.ml2}>
	<Icon src={Download} />
	</View>
	)}

Into this

{props.shouldShowDownloadIcon && (
    <View style={styles.ml2}>
        <Tooltip text={props.translate('common.download')}>
            <Icon src={Download} />
        </Tooltip>
    </View>
)}

Result

[parasharrajat]

I think it should be handled by Either #4661 or #4736 whichever was later.

[kakajann]

Hmm, both merged

[parasharrajat]

Yeah one of this should have added it so a follow up probably.

[akshayasalvi]

Hi, I'll add this as well.

[akshayasalvi]

PR is raised. I recently saw w ehave added tooltip from the other PR. Missed it.

[MelvinBot]

Triggered auto assignment to @kadiealexander (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[parasharrajat]

Not sure if this needs to be exported as this issue is found during feature testing.

Issue was found when executing #4661

[mananjadhav]

Just got to it. It seems this is fixed with the PR mentioned above.

[akshayasalvi]

This change is deployed on staging.

[kadiealexander]

Thanks for fixing this @akshayasalvi!! :)

[botify]

🚀 Deployed to staging by @sketchydroide in version: 1.0.88-3 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

[botify]

🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[botify]

🚀 Deployed to production by @roryabraham in version: 1.0.90-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[kadiealexander]

@akshayasalvi I apologise, I misunderstood @parasharrajat's comment earlier and thought this job doesn't require compensation. I've created the Upwork job here https://www.upwork.com/jobs/~015eb32b62c94f673a please apply so I can hire you and get you paid for this. Thanks!

[akshayasalvi]

@kadiealexander I am not sure if this requires payment. When I implemented my PR, I guess Tooltip work wasn't done. I covered it because I thought I'll complete the work. Nevertheless, I've applied to the Upwork, I let you and the team decide on the payment part.

[kadiealexander]

Thanks Akshaya!! I apologise for the confusion here. I've asked the team how we would usually deal with issues like this and will leave it up to the majority. Will let you know!

[akshayasalvi]

Thanks @kadiealexander. Appreciate your help

[kadiealexander]

Hi @akshayasalvi, the team decided instead of dealing with this separately, we will add a $100 bonus to the initial Upwork post here for the additional work you did here. Thanks again!!

[akshayasalvi]

Thank you @kadiealexander. Appreciate it