Sign in – Unable to login via Magic link, Magic code expired appears

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.27-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4906568
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. In Sign in page enter new Expensify email
3. Open email and copy Magic link
4. Change it to staging and navigate to it in a new tab

Expected Result:

Abracadabra page opens. We have KI #44600

Actual Result:

Magic code expired appears

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6588552_1725081784278.magic_link.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @danieldoglas (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[ishpaul777]

Can't reproduce, tried multiple times

Screen.Recording.2024-09-02.at.2.10.02.AM.mov

[danieldoglas]

@IuliiaHerets can you try this one again? Looks like you were logged in on a tab already on your video, so maybe that's why?

[danieldoglas]

not a deploy blocker for the API since it doesn't happen in production

[IuliiaHerets]

@danieldoglas Issue is still reproducible, build - v9.0.27-0

Screenrecorder-2024-09-02-20-39-56-247.mp4

[ishpaul777]

We are awaiting proposals

[danieldoglas]

@ishpaul777 are you able to reproduce this now?

[ishpaul777]

Lol no, my instinct kicked in and i wrote "awaiting proposal", what i mean is waiting reliable steps to repro

Screen.Recording.2024-09-05.at.1.38.57.AM.mov

[deetergp]

I just ran into this on staging by sending an Invoice from one user to an email address that does not yet have an Expensify account. I was able to reproduce a second time by sending to another email without an account.

[danieldoglas]

nice, thanks for that @deetergp . @ishpaul777 can you try those steps and confirm it still fails? Then we can open it for external proposals.

[ishpaul777]

Seems we have a existing issue that we can not send a invoice to any user.

https://expensify.slack.com/archives/C01GTK53T8Q/p1725613866403789

[eVoloshchak]

@danieldoglas, according to this thread I'll be taking this over as C+ from @ishpaul777

Could you re-assign this please?

Is the backend not returning something, or is it something in the app?

I haven't looked into this too closely, could be either of those just by looking at the code, but I suspect this is a back-end issue. Let's not make it External just yet, I'll look into this closer and post my findings tomorrow

[danieldoglas]

Done, assigning @eVoloshchak to it!

[izarutskaya]

Hi @CortneyOfstad No adjustment to the reproducible steps. It is stell reproducible according steps. Build v9.1.14-4

Recording.3017.mp4

[eVoloshchak]

It's not clear whether it's purely a back-end issue, should we open this for proposals?

[danieldoglas]

@eVoloshchak you said you were going to post your findings, what were those?

[eVoloshchak]

Wasn't able to find anything, we display the Magic Code Expired modal if auth session state is failed (which it is in this case).
But it's not clear why authentication is failing (is this a back-end issue with not being able to sign in accounts that are not yet verified or is it something about the new accounts that we're handling incorrectly on the front end)

[CortneyOfstad]

Hey @danieldoglas @eVoloshchak! I am going to be heading OoO this afternoon so if this needs BZ action, please re-assign the label. Otherwise I will review when I get back!

[CortneyOfstad]

Back from OoO — @eVoloshchak and @danieldoglas — where are we at with this?

[danieldoglas]

bump @eVoloshchak . Anything else you could find?

[mvtglobally]

Issue is reproducible during KI retests.

Unable to login via Magic link, Magic code expired appears

[eVoloshchak]

@danieldoglas, traced this back to SignInUserWithLink API request returning an error

We do send the correct account ID and validation code, should be working

This is probably a BE issue, I suggest we make this Internal

[danieldoglas]

Interesting - thanks for sending the requestID, that was very helpful.

I can see that we received the validate code correctly, but looks like it didn't match the one we had available in the DB. I'll investigate more.

[CortneyOfstad]

Thanks @danieldoglas!

[CortneyOfstad]

Hey @danieldoglas — just checking in to see if there were any updates on this. Thanks!

[danieldoglas]

I think I know what's kind of going on here, but I'll need some time to discuss. Changing this to weekly while I finish some other pressing matters, but it's on my radar.

[CortneyOfstad]

Sounds good — thanks @danieldoglas!

[CortneyOfstad]

Hey @danieldoglas — just checking to see if we have a rough ETA when this will be looked at? Thanks!

[CortneyOfstad]

Bump @danieldoglas ^^^ thanks!

[danieldoglas]

Still on my list, but not a huge priority compared to some other tasks.

I'm going to try to prioritize this in the next week

[CortneyOfstad]

Sounds good @danieldoglas — thank you!