[Workspace Feeds] Expensify Card - Card name does not change each time a different member is selected

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.27
Reproducible in staging?: Y
Reproducible in production?: N
Issue was found when executing this PR: Exp #48317
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• Workspace has bank account set up.
• Workspace has a few members.

1. Go to staging.new.expensify.com
2. Go to Workspace settings > Expensify Card.
3. Click Issue new card.
4. Select Member A.
5. Proceed all the way to the confirmation page (final step) but do not click Issue card button.
   6.Click RHP back button to return to the first step which is member selection page.
6. Select Member B.
7. Proceed to "Give it a name" step.
8. Note that the name is still Member A instead of Member B.
9. Go to Members.
10. Click on Member C.
11. Click New card.
12. Proceed to "Give it a name" step.
13. Note that the name is still Member A instead of Member C.

Expected Result:

In Step 9 and 14, the card name should change each time a different user is selected.

Actual Result:

In Step 9 and 14, the card name does not change each time a different user is selected.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6588259_1725054667879.20240831_054036.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @pecanoro (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In Step 9 and 14, the card name does not change each time a different user is selected.

What is the root cause of that problem?

Currently, in the CardNameStep component, we are displaying the cardTitle from Onyx ISSUE_NEW_EXPENSIFY_CARD if it exists.

App/src/pages/workspace/expensifyCard/issueNew/CardNameStep.tsx

Line 96 in 117b961

defaultValue={issueNewCard?.data?.cardTitle ?? defaultCardTitle}

What changes do you think we should make in order to solve the problem?

We should update the cardTitle when the user returns to the step of selecting the assignee and not isEditing here.

        data: {
            assigneeEmail: assignee?.login ?? '',
            cardTitle: isEditing ? issueNewCard.data.cardTitle : '',
        }

And update this condition to show defaultCardTitle when cardTitle is empty string

         defaultValue={issueNewCard?.data?.cardTitle || defaultCardTitle}

What alternative solutions did you explore? (Optional)

NA

[koko57]

As I am the author of the PR that caused the regression I would like to fix it. It should not be a deploy blocker as the functionality is behind the beta.

cc @mountiny

[mountiny]

Not a blocker this is behind beta

[mountiny]

@koko57 are you able to fix this in one of the PRs for a clean up

[koko57]

PR opened #48408

[trjExpensify]

This is on prod, closing.