Skip to content

Payment issue for E/App PR#47417 #47620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
melvin-bot bot opened this issue Aug 19, 2024 · 12 comments
Closed

Payment issue for E/App PR#47417 #47620

melvin-bot bot opened this issue Aug 19, 2024 · 12 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Task

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 19, 2024

Issue created to compensate the Contributor+ member for their work on #47417
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/408257.
Contributor+ member who reviewed the PR - @mkhutornyi.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

@melvin-bot melvin-bot bot added Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Task Weekly KSv2 labels Aug 19, 2024
@melvin-bot melvin-bot bot added the Internal Requires API changes or must be handled by Expensify staff label Aug 19, 2024
Copy link
Author

melvin-bot bot commented Aug 19, 2024

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Aug 19, 2024
@johncschuster
Copy link
Contributor

Waiting on the regression threshold to pass

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Overdue Daily KSv2 labels Aug 21, 2024
@johncschuster
Copy link
Contributor

#47417

Looks like the regression threshold just cleared. I need to check in on the payment. I'll get this sorted first thing in the AM

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Aug 27, 2024
@johncschuster
Copy link
Contributor

I will issue payment in the AM

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Aug 30, 2024
Copy link
Author

melvin-bot bot commented Sep 2, 2024

@johncschuster @mkhutornyi this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Copy link
Author

melvin-bot bot commented Sep 3, 2024

@johncschuster, @mkhutornyi Whoops! This issue is 2 days overdue. Let's get this updated quick!

@johncschuster
Copy link
Contributor

Sorry for the delay here! I'm looking for guidance on the payment amounts for Help Site article reviews and have had trouble finding it. I've reached out to @maddylewis for a point in the right direction, and will be back to pay this out ASAP!

@melvin-bot melvin-bot bot removed the Overdue label Sep 3, 2024
@johncschuster
Copy link
Contributor

Ok! I've gotten this sorted. So, it turns out these shouldn't be randomly distributed via PullerBear. I think that was our mistake.

@mkhutornyi, just a heads up, we don't typically pay these reviews out, as we have a contract with a single engineer to review these. We'll do better on our end to make sure Help Site article reviews are assigned to the reviewing engineer.

That said, thank you for reviewing this! Please accept the job here so I can issue payment for your work!

@melvin-bot melvin-bot bot added the Overdue label Sep 6, 2024
@johncschuster
Copy link
Contributor

Bump!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Sep 6, 2024
@johncschuster
Copy link
Contributor

Bump!

@melvin-bot melvin-bot bot removed the Overdue label Sep 9, 2024
@mkhutornyi
Copy link
Contributor

Accepted thanks

@johncschuster
Copy link
Contributor

Paid! Thanks for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Task
Projects
None yet
Development

No branches or pull requests

2 participants