[$250] Expense - Expense report stays "pinned" to LHN after it is exported to CSV

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.18-7
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit an expense and pay it.
4. Go to Search > Shared.
5. Select the paid expense in Step 3.
6. Click on the dropdown > Download.
7. Return to Inbox.
8. Open any report other than the paid expense report in Step 3.

Expected Result:

The expense report will not remain in LHN when another report is opened.

Actual Result:

Expense report stays "pinned" to LHN after it is exported to CSV.
It remains in LHN even when another report is opened.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6566540_1723198262652.20240809_180517.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017f803bf9c62b72a5
• Upwork Job ID: 1823174429757887078
• Last Price Increase: 2024-08-20
• Automatic offers:
• rayane-djouah | Reviewer | 103650314

Issue Owner

Current Issue Owner: @rayane-djouah

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 1

[IuliiaHerets]

@VictoriaExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[melvin-bot]

@VictoriaExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[VictoriaExpensify]

Agree this is an issue we should fix!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017f803bf9c62b72a5

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

[rayane-d]

Waiting on proposals

[burczu]

Hi, I’m Bartek from Callstack and I would like to work on this issue.

[rayane-d]

@VictoriaExpensify - Let's assign @burczu ^^ Thanks

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[burczu]

Hmm... frankly I'm not able to reproduce the issue:

Screen.Recording.2024-08-23.at.08.15.45.mov

But, there is a distinction comparing to steps to reproduce posten in this issue - I can't see the "Shared" option in the search panel. Is it something I can turn on in the Workspace settings or smth?

[rayane-d]

@burczu - I think "Outstanding" / "Approved" statuses are the new equivalent to "Shared" status

[rayane-d]

The PR introducing the new status bar was reverted. you can merge main to get the older options

[burczu]

@rayane-djouah Synced with latest main and indeed the "Shared" status shows up now, thanks. Moreover the bug occurs in this case... so I'll try to find solution now.

@VictoriaExpensify Could you please assign me?

[rayane-d]

@VictoriaExpensify is OOO, I will ask in Slack for someone else

[melvin-bot]

📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

@burczu @VictoriaExpensify @rayane-djouah this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@burczu, @VictoriaExpensify, @rayane-djouah Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[rayane-d]

@burczu is working on this one

[burczu]

I've done my research and I suspect this issue comes from the backend side.

Before we export the expense report as CSV, the notificationPreference of it is set to "hidden". After we download the report in the Search -> Shared panel, the backend pushes the changes to the report and the notificationPreference is changed to "always" along with additional comment added to the report: "exported this report to CSV" (I've checked and it seems no Onyx action is called on the frontend side that may change these values) - that's the reason it stays "pinned" from now on. Please take a look at the video below:

Screen.Recording.2024-08-28.at.09.16.50.mov

[trjExpensify]

I'm a bit confused by the issue, I don't think it's overly clear from the OP what priorityMode is being used, nor does this screenshot make it seem as though the report is pinned or the user is in #focus mode.

[trjExpensify]

CC'ing a few peeps for vis and context on these features: @deetergp @rlinoz @JmillsExpensify

[rayane-d]

Not overdue

[melvin-bot]

@burczu, @VictoriaExpensify, @rayane-djouah Whoops! This issue is 2 days overdue. Let's get this updated quick!

[rayane-d]

I'm unassigning myself as this needs to be fixed internally on the backend. Please let me know if you need anything from me

[VictoriaExpensify]

Oof yeah, I think this needs some further triaging, actually. I'm going to have another play around between the Focus and Most Recent modes and get more clarity on the issue

[rlinoz]

I think the wording is a bit confusing since the report is not pinned, but adding the action is making you "join" the report as @burczu stated here:

the backend pushes the changes to the report and the notificationPreference is changed to "always" along with additional comment added to the report: "exported this report to CSV"

I can take this one!

[rlinoz]

PR is deployed and this should now be fixed.