Skip to content

[Workspace Feeds] Integrate OpenPolicyEditCardLimitTypePage api command to the app #46959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mountiny opened this issue Aug 7, 2024 · 9 comments
Assignees
Labels
NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@mountiny
Copy link
Contributor

mountiny commented Aug 7, 2024

The PR to add a new OpenPolicyEditCardLimitTypePage API command was merged https://github.com/Expensify/Web-Expensify/pull/42964

It is called when the Edit card limit type page is opened by admin, and the command returns unapprovedSpend and totalSpend inside the card data object, which are both negative values (or zero).

Then using these values we can decide which card limit options we show based on the breakdown provided by @MariaHCD here https://expensify.slack.com/archives/C036QM0SLJK/p1721311425532449

The params are:

  • string authtoken
  • string policyID
  • int cardID
Copy link

melvin-bot bot commented Aug 7, 2024

Triggered auto assignment to @garrettmknight (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@mountiny
Copy link
Contributor Author

mountiny commented Aug 7, 2024

@garrettmknight no need for BZ assignee here

@mountiny
Copy link
Contributor Author

mountiny commented Aug 7, 2024

@koko57 will you handle this one or should we assign someone else from Callstack?

@koko57
Copy link
Contributor

koko57 commented Aug 7, 2024

@mountiny maybe @waterim could handle this one, he has some capacity right now 🙂

@waterim
Copy link
Contributor

waterim commented Aug 7, 2024

Hello, Im Artem from Callstack and would like to help with this one!

@trjExpensify trjExpensify moved this to Release 2: Summer 2024 (Aug) in [#whatsnext] #wave-collect Aug 7, 2024
@trjExpensify trjExpensify added Daily KSv2 and removed Weekly KSv2 labels Aug 7, 2024
@mountiny
Copy link
Contributor Author

mountiny commented Aug 7, 2024

Nice thanks, @waterim ping us in Slack with any sort of questions. Please read through the linked slack thread in the OP

@allgandalf
Copy link
Contributor

Sorry, was stuck with something super urgent internally 🔥 (slack for reference) and then weekend hit, I will review the PR today

@allgandalf
Copy link
Contributor

This PR was merged 🚀

@mountiny
Copy link
Contributor Author

So I believe we can close this one out 🎉

@github-project-automation github-project-automation bot moved this from Release 2: Summer 2024 (Aug) to Done in [#whatsnext] #wave-collect Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
Status: Done
Development

No branches or pull requests

8 participants