Skip to content

[Hold for #46324] Search - Draft message inside the composer disappears in expense details page #46772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 6 tasks
lanitochka17 opened this issue Aug 3, 2024 · 12 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Reviewing Has a PR in review

Comments

@lanitochka17
Copy link

lanitochka17 commented Aug 3, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.16-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Create an expense
  3. Go to search
  4. Click on an expense from the expense list
  5. Write something inside the composer
  6. Go back to inbox
  7. Observe that the text inside the composer is visible
  8. Click on chat where the expense is submitted from the LHN
  9. Open the expense details page by clicking on the preview

Expected Result:

The drafted message inside the composer should be present

Actual Result:

The draft message inside the composer disappears and the composer gets empty

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6554984_1722117649352.4_5848162808948069384.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 3, 2024
Copy link

melvin-bot bot commented Aug 3, 2024

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp

@lanitochka17
Copy link
Author

@sonialiap FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@FitseTLT
Copy link
Contributor

FitseTLT commented Aug 5, 2024

Same root cause as #45408
Tagging @luacmartins

@sonialiap
Copy link
Contributor

@luacmartins do you think this issue will be, or can be covered by #45408?

@luacmartins
Copy link
Contributor

Yea, this issue should be fixed once #46324 is merged.

@luacmartins luacmartins added the Reviewing Has a PR in review label Aug 6, 2024
@luacmartins luacmartins self-assigned this Aug 6, 2024
@sonialiap sonialiap changed the title Search - Draft message inside the composer disappears in expense details page [Hold for #46324] Search - Draft message inside the composer disappears in expense details page Aug 13, 2024
Copy link

melvin-bot bot commented Aug 13, 2024

@sonialiap, @luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Aug 15, 2024

@sonialiap, @luacmartins Huh... This is 4 days overdue. Who can take care of this?

Copy link

melvin-bot bot commented Aug 16, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@sonialiap sonialiap added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Aug 16, 2024
Copy link

melvin-bot bot commented Aug 16, 2024

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@sonialiap
Copy link
Contributor

@twisterdotcom I'm OOO Aug 19-30, adding leave buddy.
Status: once #46324 is sorted, we'll need to retest to confirm if that PR also fixed this issue

@luacmartins
Copy link
Contributor

luacmartins commented Aug 23, 2024

This was fixed internally. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

5 participants