Skip to content

[Workspace Feeds] [External] Integrate Deactivate_Card API #44320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mountiny opened this issue Jun 24, 2024 · 29 comments
Closed

[Workspace Feeds] [External] Integrate Deactivate_Card API #44320

mountiny opened this issue Jun 24, 2024 · 29 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Reviewing Has a PR in review Weekly KSv2

Comments

@mountiny
Copy link
Contributor

Part of the Workspace feeds project.

Implement the following part of the design doc.

@koko57 @VickyStash @allgandalf @DylanDylann

Copy link

melvin-bot bot commented Jun 28, 2024

@MariaHCD, @mountiny Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@mountiny mountiny added Weekly KSv2 and removed Daily KSv2 labels Jun 28, 2024
@mountiny
Copy link
Contributor Author

Later phase of implementation

@melvin-bot melvin-bot bot removed the Overdue label Jun 28, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 8, 2024
@mountiny
Copy link
Contributor Author

Will be worked on soon

@melvin-bot melvin-bot bot removed the Overdue label Jul 10, 2024
@waterim
Copy link
Contributor

waterim commented Jul 15, 2024

Hello Im Artem from Callstack and would like to work on this issue

@trjExpensify
Copy link
Contributor

Assigned you, @waterim!

@trjExpensify trjExpensify added Daily KSv2 and removed Weekly KSv2 labels Jul 16, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jul 18, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 25, 2024
@melvin-bot melvin-bot bot changed the title [Workspace Feeds] [External] Create Deactivate card logic [HOLD for payment 2024-08-01] [Workspace Feeds] [External] Create Deactivate card logic Jul 25, 2024
@mountiny
Copy link
Contributor Author

We will bump this in the next update for the project

@melvin-bot melvin-bot bot removed the Overdue label Aug 14, 2024
@mountiny
Copy link
Contributor Author

We still need to integrate this with the API

@mountiny mountiny changed the title [HOLD for payment 2024-08-01] [Workspace Feeds] [External] Create Deactivate card logic [Workspace Feeds] [External] Integrate Deactivate_Card API Aug 14, 2024
@melvin-bot melvin-bot bot added the Overdue label Aug 16, 2024
Copy link

melvin-bot bot commented Aug 19, 2024

@MariaHCD, @kevinksullivan, @mountiny, @waterim, @DylanDylann Eep! 4 days overdue now. Issues have feelings too...

@koko57
Copy link
Contributor

koko57 commented Aug 20, 2024

@mountiny let me know when the BE is ready for this one

Copy link

melvin-bot bot commented Aug 21, 2024

@MariaHCD, @kevinksullivan, @mountiny, @waterim, @DylanDylann Still overdue 6 days?! Let's take care of this!

@MariaHCD
Copy link
Contributor

We're working on the BE: https://github.com/Expensify/Auth/pull/12150

@melvin-bot melvin-bot bot removed the Overdue label Aug 21, 2024
@MariaHCD
Copy link
Contributor

@koko57 The BE is ready!

As a note, the initial approach we had in the design doc is now outdated

For physical cards, we will call Card_Deactivate command with cardID, for virtual - Card_EditAdminIssuedVirtualCard with a cardLimit of 0. This will lead to the card being deactivated.

We will be using a single API command: Card_Deactivate that accepts a string authToken and int cardID for both physical cards and virtual cards.

@koko57
Copy link
Contributor

koko57 commented Aug 22, 2024

@MariaHCD ok, thanks! Me or someone from our team will take care of it

@VickyStash
Copy link
Contributor

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on Card_Deactivate integration.

@trjExpensify
Copy link
Contributor

Assigned you, @VickyStash!

@VickyStash
Copy link
Contributor

Updates: I've implemented the Card_Deactivate API call and working on the UI updates to support deactivated cards. I think the PR should be ready on Monday.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Aug 26, 2024
@VickyStash
Copy link
Contributor

The PR is ready for the review!

@melvin-bot melvin-bot bot added the Overdue label Aug 26, 2024
@mountiny
Copy link
Contributor Author

PR is actively being worked on

@melvin-bot melvin-bot bot removed the Overdue label Aug 27, 2024
@kevinksullivan
Copy link
Contributor

unassigning myself as I am going OOO. If we end up needing a payment (I don't believe we do) just put the bug label back on this!

@kevinksullivan kevinksullivan removed their assignment Sep 12, 2024
@mountiny
Copy link
Contributor Author

This is done

@github-project-automation github-project-automation bot moved this from Release 2: Summer 2024 (Aug) to Done in [#whatsnext] #wave-collect Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Reviewing Has a PR in review Weekly KSv2
Projects
Status: Done
Development

No branches or pull requests

8 participants