Skip to content

Revert changes to add payment method button #4238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
5 tasks done
stitesExpensify opened this issue Jul 26, 2021 · 8 comments
Closed
5 tasks done

Revert changes to add payment method button #4238

stitesExpensify opened this issue Jul 26, 2021 · 8 comments
Assignees
Labels
Daily KSv2 Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review

Comments

@stitesExpensify
Copy link
Contributor

Problem

In this issue we mislead a contributor to add some changes we don't actually. want.

Solution

  1. We're getting the paypal.me nvp in getUserDetails now, we should get it exclusively in getPaymentMethods
  2. We should never be hiding the "add payment method" button since we're going to be adding the ability for bank accounts to be added there and you can have as many as you want

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web
@stitesExpensify stitesExpensify added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels Jul 26, 2021
@stitesExpensify stitesExpensify self-assigned this Jul 26, 2021
@MelvinBot
Copy link

Triggered auto assignment to @laurenreidexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Jul 26, 2021
@stitesExpensify
Copy link
Contributor Author

@laurenreidexpensify unassigning you because this is an issue I'm creating for myself

@stitesExpensify stitesExpensify added Improvement Item broken or needs improvement. Engineering Reviewing Has a PR in review labels Jul 28, 2021
@MelvinBot
Copy link

@stitesExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@stitesExpensify
Copy link
Contributor Author

This is merged and on staging

@MelvinBot
Copy link

@stitesExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@MelvinBot
Copy link

@stitesExpensify Still overdue 6 days?! Let's take care of this!

@MelvinBot
Copy link

@stitesExpensify 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

@stitesExpensify
Copy link
Contributor Author

This has been on prod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

3 participants