-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Bank account label in Workspace > Workflows > Make or track payments is too small #40204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Triggered auto assignment to @slafortune ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Bank account label in Workspace > Workflows > Make or track payments is too small What is the root cause of that problem?When
What changes do you think we should make in order to solve the problem?We should also check for titleStyle={hasVBA && bankDisplayName ? styles.textLabelSupportingNormal : styles.textLabelSupportingEmptyValue} What alternative solutions did you explore? (Optional) |
ProposalPlease re-state the problem that we are trying to solve in this issue.Incorrect font size for What is the root cause of that problem?Currently, when we click on Lines 193 to 200 in db9e01c
Now, this will set the style of the text to What changes do you think we should make in order to solve the problem?We should add a extra boolean condition like we do when we check which one to display between App/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx Lines 182 to 186 in db9e01c
Update : App/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx Lines 179 to 180 in db9e01c
To: <MenuItem
titleStyle={ hasVBA && policy?.reimbursementChoice === CONST.POLICY.REIMBURSEMENT_CHOICES.REIMBURSEMENT_YES ? styles.textLabelSupportingNormal : styles.textLabelSupportingEmptyValue}
What alternative solutions did you explore? (Optional) |
This issue will fix here #39947, it has the same root cause. The style condition is correct Tested in last main. Screen.Recording.2024-04-13.at.9.26.42.PM.mov |
I can confirm that this issue will be fixed as part of the already open PR #40182 from issue: Specifically the following lines of code: |
Thanks @ikevin127 , in that case, let's close this 👍 |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.4.62-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1712858899464959
Action Performed:
Expected Result:
When there is no bank account added, the label for "Bank account" should be 15px in size
Actual Result:
The label is too small and is 13px in size
Workaround:
unknonw
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Recording.5.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: