Clean up the getOutstandingChildRequest logic to match holistically what is in backend

[mountiny]

The getOutstandingChildRequest logic is used to determine if the chat should have GBR in relation to money request. There is many cases this can work so we should make sure we correctly handle this optimistically.

I will try to clean this up to match the backend logic as much as possible to avoid any flashing of the GBR

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f7e94d9a1d232c0e
• Upwork Job ID: 1777725361246265344
• Last Price Increase: 2024-04-09

Issue Owner

Current Issue Owner: @mountiny

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f7e94d9a1d232c0e

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @parasharrajat (Internal)

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[mountiny]

Making ths weekly now as I am not sure I will get to this tomorrow and then I am ooo

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[stephanieelliott]

Reapplying the Bug label to get another BZ member on this while I am OOO til May 2. Thanks @laurenreidexpensify I'll grab this back from you when I return!

[mountiny]

Still havent got to this as its clean up

[melvin-bot]

@parasharrajat @stephanieelliott @mountiny @laurenreidexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[trjExpensify]

Gotcha, so you're saying right now the GBR is not applied if an admin submits a report to themselves for example?

[mountiny]

Screen.Recording.2024-08-15.at.16.46.45.mov

Yeah you saw the delay in there

Screen.Recording.2024-08-15.at.16.54.45.mov

When offline no GBR

[trjExpensify]

Ah right okay, so online there's a delay and offline it's not there at all.

I guess it's not that important, but it is incorrect.

[mountiny]

Still in a backlog

[mountiny]

low

[mountiny]

same

[parasharrajat]

@mountiny Any plan for this yet?

[mountiny]

i will have to circle back to this one, prioritizing other issues now

[mountiny]

low

[mountiny]

low

[mountiny]

Low

[mountiny]

low