[HOLD for payment 2024-05-09] [$250][Search v1] Create TransactionListItem

[luacmartins]

Section from design doc

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011106ccde6345e3fb
• Upwork Job ID: 1780007627945009152
• Last Price Increase: 2024-04-15
• Automatic offers:
• dukenv0307 | Reviewer | 0
• rayane-djouah | Contributor | 0

Issue Owner

Current Issue Owner: @jliexpensify

[melvin-bot]

@luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011106ccde6345e3fb

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

[WojtekBoman]

Hi! I'm going to work on that :)

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

Triggered auto assignment to @jliexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[luacmartins]

I'm merging the PR above since SWM will be ooo for the rest of the week and the functionality is not yet available to users. I'll continue to work on it myself in the meantime.

[melvin-bot]

📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.69-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA][Search v1] TransactionListItem and SearchTableHeader #41102

If no regressions arise, payment will be issued on 2024-05-09. 🎊

For reference, here are some details about the assignees on this issue:

• @WojtekBoman does not require payment (Contractor)
• @rayane-djouah requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rayane-djouah] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[jliexpensify]

Payment Summary

• C+ @rayane-djouah: $250 (can you also do the checklist please, if applicable?)

UPWORKS JOB

I see that @dukenv0307 is also hired but he was unassigned from this GH so I assume he's not being paid? cc @luacmartins

[jliexpensify]

Confirming with @luacmartins that @dukenv0307 shouldn't be paid.

[rayane-d]

Regression Test Proposal

1. Log in with an account that has multiple transactions or create them.
2. Navigate to Profile > Troubleshoot > New Search Page.
3. Verify that a skeleton loader is displayed when loading data.
4. Verify that the table header and the transaction items are visible.
5. On wide screens, verify that the following table headers are included: Date, Merchant/Description, From, To, Total, Type, and Action.
6. On small screens, verify that From, To, and Merchant/Description info are displayed in the left part, and Action, Total, Type, and Date info are displayed in the right part.
7. On small screens, verify that the (user -> user) is left-aligned in transaction items.
8. Ensure that the entire row of a transaction item is clickable.
9. Verify that clicking on a transaction item opens the transaction thread in the RHP.
10. Verify that the users/workspaces avatars are correct.
11. Confirm that the default workspace avatars are correctly colored.
12. Ensure that a long display name/email is truncated in transaction items.
13. Verify that there are no "fake" reports included in transaction items.
14. Confirm that all transactions are shared with you and there are no incorrect transactions.
15. Ensure that the merchant column is always shown for workspace expenses instead of the description column. Off-workspace, display the Merchant column as long as at least one value isn’t “Request” or “Unknown merchant”. In all other cases, show the Description column as long as at least one expense has one.

• Do we agree 👍 or 👎

[luacmartins]

Confirming with @luacmartins that @dukenv0307 shouldn't be paid.

Correct, I asked for an expedited review and assigned @rayane-djouah to review the PR instead

[luacmartins]

No need to add tests now, we'll do so once we conclude the project using the manual test script from the design doc.

[jliexpensify]

Thanks Carlos for confirming! I'll pay and close this today.

[jliexpensify]

Paid and job closed.