Skip to content

Remove (NEW!) message after logout and update it to be unread count #3971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 5 tasks
tugbadogan opened this issue Jul 10, 2021 · 8 comments
Closed
1 of 5 tasks
Assignees
Labels
Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@tugbadogan
Copy link
Contributor

tugbadogan commented Jul 10, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  • Log in to a user
  • Make sure user has unread messages and web page has (NEW!) phrase in the title
  • If there's no unread messages, mark a message as unread
  • Log out

Expected Result:

Let's update this in the following two ways:

  1. Instead of appending (NEW!) when there are new messages, let's append (1) which is a count of the number of unread messages (similar to the desktop app icon shown below.
  2. The (1) message (currently (NEW!)) should be removed from the title bar upon logout.

image

Actual Result:

(NEW!) phrase stays in the page title

Screen.Recording.2021-07-10.at.16.04.06.mov

Workaround:

It doesn't prevent user from logging in or refreshing the page

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: v1.0.76-2
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:

View all open jobs on Upwork

@tugbadogan tugbadogan added the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Jul 10, 2021
@MelvinBot
Copy link

Triggered auto assignment to @puneetlath (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Jul 10, 2021
@puneetlath
Copy link
Contributor

@Expensify/design what should this be now that we moved from expensify.cash to new.expensify? Should the tab title just be "New Expensify" permanently?

@shawnborton
Copy link
Contributor

That makes sense to me.

@puneetlath
Copy link
Contributor

Started a discussion here about it: https://expensify.slack.com/archives/C01GTK53T8Q/p1626880473073100

@MelvinBot MelvinBot added the Monthly KSv2 label Jul 21, 2021
@puneetlath puneetlath changed the title (NEW!) message title stays after logout Remove (NEW!) message after logout and update it to be unread count Jul 26, 2021
@puneetlath
Copy link
Contributor

Ok I updated the issues based on that discussion. Done triaging, so unassigning myself and assigning Engineering !

@puneetlath puneetlath removed their assignment Jul 26, 2021
@puneetlath puneetlath added Daily KSv2 Engineering and removed Monthly KSv2 labels Jul 26, 2021
@MelvinBot
Copy link

Triggered auto assignment to @HorusGoul (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@MelvinBot
Copy link

@HorusGoul Whoops! This issue is 2 days overdue. Let's get this updated quick!

@MelvinBot
Copy link

@HorusGoul Huh... This is 4 days overdue. Who can take care of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

5 participants