-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Remove (NEW!) message after logout and update it to be unread count #3971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Triggered auto assignment to @puneetlath ( |
@Expensify/design what should this be now that we moved from expensify.cash to new.expensify? Should the tab title just be "New Expensify" permanently? |
That makes sense to me. |
Started a discussion here about it: https://expensify.slack.com/archives/C01GTK53T8Q/p1626880473073100 |
Ok I updated the issues based on that discussion. Done triaging, so unassigning myself and assigning Engineering ! |
Triggered auto assignment to @HorusGoul ( |
@HorusGoul Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@HorusGoul Huh... This is 4 days overdue. Who can take care of this? |
Uh oh!
There was an error while loading. Please reload this page.
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
(NEW!)
phrase in the titleExpected Result:
Let's update this in the following two ways:
(NEW!)
when there are new messages, let's append(1)
which is a count of the number of unread messages (similar to the desktop app icon shown below.(1)
message (currently(NEW!)
) should be removed from the title bar upon logout.Actual Result:
(NEW!)
phrase stays in the page titleScreen.Recording.2021-07-10.at.16.04.06.mov
Workaround:
It doesn't prevent user from logging in or refreshing the page
Platform:
Where is this issue occurring?
Version Number: v1.0.76-2
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
View all open jobs on Upwork
The text was updated successfully, but these errors were encountered: