Skip to content

Attachment-App crashes when scrubbing through an mp4 file on attachment upload preview #36905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 6 tasks
lanitochka17 opened this issue Feb 20, 2024 · 20 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Reviewing Has a PR in review

Comments

@lanitochka17
Copy link

lanitochka17 commented Feb 20, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.43-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4331252
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Open a chat on ND
  2. Click on plus icon inside the compose box
  3. Click on add attachment
  4. Click on choose from gallery
  5. Select an mp4 video
  6. When the preview opens up play the video and manually scrub through the video using the progress bar

Expected Result:

App should play the video normally

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6385670_1708432555805.Crash_with_video.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment External Added to denote the issue can be worked on by a contributor labels Feb 20, 2024
Copy link

melvin-bot bot commented Feb 20, 2024

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 20, 2024
Copy link

melvin-bot bot commented Feb 20, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

@melvin-bot melvin-bot bot added the Daily KSv2 label Feb 20, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 20, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 20, 2024

Triggered auto assignment to @rlinoz (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp
CC @quinthar

@rlinoz
Copy link
Contributor

rlinoz commented Feb 20, 2024

Related to #30829

@kowczarz
Copy link
Contributor

Hey! I'm not sure if I should write proposal since the fix is quite straight forward and we need to fix it as quick as it's possible. Cc. @mountiny

@shubham1206agra
Copy link
Contributor

Maybe a tiny explanation on PR itself will work.

Copy link

melvin-bot bot commented Feb 21, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@mountiny
Copy link
Contributor

@kowczarz no need for proposals on this

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Feb 22, 2024
Copy link

melvin-bot bot commented Feb 23, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@chiragsalian chiragsalian removed the DeployBlockerCash This issue or pull request should block deployment label Feb 23, 2024
@chiragsalian
Copy link
Contributor

Removing blocker label since the PR was CP-d to staging.

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@rlinoz rlinoz added the Bug Something is broken. Auto assigns a BugZero manager. label Mar 5, 2024
Copy link

melvin-bot bot commented Mar 5, 2024

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Mar 5, 2024
@rlinoz
Copy link
Contributor

rlinoz commented Mar 5, 2024

This is actually done and @shubham1206agra was the C+ reviewer.

@isabelastisser
Copy link
Contributor

Thanks for the heads up @rlinoz!

@shubham1206agra, I've sent you an offer in Upwork now, please accept it and I will process the payment. Thanks!

All set.

@shubham1206agra
Copy link
Contributor

@isabelastisser Why the offer of $250? Is there a reason for this?

@isabelastisser
Copy link
Contributor

@rlinoz @shubham1206agra, can you please confirm the payment amount for the C+ review here? Is it the standard $500?

@isabelastisser isabelastisser reopened this Mar 5, 2024
@rlinoz
Copy link
Contributor

rlinoz commented Mar 5, 2024

Yeah, it should be the standard rate

@isabelastisser
Copy link
Contributor

Thanks! I updated the payment amount an d processed it in Upwork. All set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

8 participants