[Wave8] [Simplified Collect] Remove the free workspace menu items from collect workspace settings in NewDot

[trjExpensify]

👋 We've started working on the PRs (like here and here) to implement the new workspace settings for collect. I noticed that we're showing the old free menu items in the LHN of the workspace settings along with the new menu items being added to collect workspaces only.

Let's remove these menu items from collect workspace settings only (leave free alone):

Cards
Reimbursements
Bills
Invoices
Travel
Bank account

Immediately then, we'll be left with:

Profile
Members

... and as we progress through implementation of release1 of wave8 in the coming weeks we'll see:

Profile
Members
Categories
Workflows

... ahead of then adding the rest and being conditional on being enabled in More features. Thanks! CC: @mountiny @luacmartins @lakchote @JmillsExpensify

[melvin-bot]

Current assignee @trjExpensify is eligible for the NewFeature assigner, not assigning anyone new.

[mountiny]

cc @ArekChr this is kinda related to your PR too #36324

Would you be interested in handling this as its good to know the context and how it will fit the other pages? cc @rushatgabhane might be interested too

[ArekChr]

Sure @mountiny, I'm interested and happy to handle it

[mountiny]

Thanks!

[rushatgabhane]

@mountiny yes please! happy to help

[trjExpensify]

Perfect, will be good for us to clear this hurdle for sure.

[lakchote]

The logic to remove the free workspace menu items is already done in my PR.

You can see how I've enabled Workflows only for collect workspaces here.

[trjExpensify]

Oh cool, so @ArekChr's PR is aligning with that for workflows yeah?

[trjExpensify]

@lakchote confirming we're done here and close this out, right?

[lakchote]

@lakchote confirming we're done here and close this out, right?

Yes!

Closing the issue.

[rushatgabhane]

Hi @trjExpensify, could you please attach payment summary for this issue. Thanks 🙇

[trjExpensify]

Ah, my bad. 😅 I didn't think there was an "independent" PR for this issue in the end. I see it now: #36672

Payment summary as follows:

$500 to @rushatgabhane for the C+ review.

Feel free to go ahead and request on NewDot :)

[JmillsExpensify]

$500 approved for @rushatgabhane based on summary.