Workspace - Workspace name is not displayed under cards, Invoices title.

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.36
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4281012
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Workspace name must be displayed under cards, Invoices title

Expected Result:

Workspace name is not displayed under cards, Invoices title

Actual Result:

Unknown

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6366556_1707028009810.az_recorder_20240203_155804.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

We think that this bug might be related to #vip-vsp
CC @quinthar

[mkhutornyi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - Workspace name is not displayed in workspace pages with sections

What is the root cause of that problem?

WorkspacePageWithSections has HeaderWithBackButton without subtitle
Same on WorkspaceMembersPage

What changes do you think we should make in order to solve the problem?

Add missing subtitle={policy?.name} in those pages

App/src/pages/workspace/WorkspacePageWithSections.tsx

Lines 156 to 161 in 3ab4e6e

	<HeaderWithBackButton
	title={headerText}
	guidesCallTaskID={guidesCallTaskID}
	shouldShowBackButton={isSmallScreenWidth || shouldShowBackButton}
	onBackButtonPress={() => Navigation.goBack(backButtonRoute ?? ROUTES.WORKSPACE_INITIAL.getRoute(policyID))}
	/>

App/src/pages/workspace/WorkspaceMembersPage.js

Lines 430 to 438 in 3ab4e6e

	<HeaderWithBackButton
	title={props.translate('workspace.common.members')}
	onBackButtonPress={() => {
	setSearchValue('');
	Navigation.goBack();
	}}
	shouldShowBackButton={isSmallScreenWidth}
	guidesCallTaskID={CONST.GUIDES_CALL_TASK_IDS.WORKSPACE_MEMBERS}
	/>

What alternative solutions did you explore? (Optional)

Depending on whether to show policy name or not, we can introduce new prop like shouldShowSubtitle in WorkspacePageWithSections and WorkspaceMembersPage
i.e. on large screen, it might be redundant because it's already showing in breadcrump. so shouldShowSubtitle={isSmallScreenWidth}

[melvin-bot]

Triggered auto assignment to @dannymcclain (Design), see these Stack Overflow questions for more details.

[mountiny]

Asking in slack about expected behaviour https://expensify.slack.com/archives/C036QM0SLJK/p1707143692876749

[mountiny]

So far I think we can close because we will overhaul this page a lot soon as part of Simplified collect