[HOLD for payment 2024-02-14] [$500] Chat - App crashes when tapping device back button to return from thread

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.36
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation:

Action Performed:

1. Open the app
2. Navigate to any chat
3. Send a message and start a thread
4. Tap the device's back button on the navigation bar or swipe left (Pixel)
5. After returning to the chat, start typing

Expected Result:

The text is displayed in the compose box, user can continue to interact with the app

Actual Result:

The app crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6366182_1706984503717.Pixel_stg.mp4

Bug6366182_1706984503714.SG_stg.mp4

Bug6366182_1706984503745!log.txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014c33c369e718efc4
• Upwork Job ID: 1753898689311535104
• Last Price Increase: 2024-02-03

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014c33c369e718efc4

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @NikkiWines (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

We think that this bug might be related to #vip-vsb
CC @quinthar

[mountiny]

@fedirjh are you able to reproduce?

[fedirjh]

@mountiny I couldn’t reproduce on dev simulator, I will retry on a real device. However, I checked the crash log and this seems to be related to live markdown feature:

[fedirjh]

cc @tomekzaw I guess this line is causing the crash.

[tomekzaw]

@fedirjh Thanks for sharing the error, are you able to share the whole stack trace as well?

[fedirjh]

@tomekzaw It's in the OP :

Bug6366182_1706984503745!log.txt

[tomekzaw]

Thanks. Please let me know if you can consistently reproduce it so we can find a better solution other that just checking if mMarkdownStyle is null or not.

[kbecciv]

Tester with Google Pixel 6, Android 14 -reproducible

az_recorder_20240205_162609.2.mp4

[kbecciv]

Samsung Galaxy A52s 5G, Android 14 - reproducible

az_recorder_20240205_151328.mp4

[tomekzaw]

Thanks, I'm working on a fix.

[thienlnam]

Will take this over as BZ

[tomekzaw]

I was able to reproduce this issue on Android emulator (Pixel 6 API 34 Android 14.0 virtual device).

[tomekzaw]

Should be fixed with #35852

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.37-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix crash when tapping device back button to return from thread #35852

If no regressions arise, payment will be issued on 2024-02-14. 🎊

For reference, here are some details about the assignees on this issue:

• @tomekzaw does not require payment (Contractor)
• @fedirjh requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@fedirjh] Determine if we should create a regression test for this bug.
• [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @tomekzaw is from an agency-contributor and not due payment
• C+: @fedirjh paid $500 via Upwork (https://www.upwork.com/nx/wm/offer/100916911)

BugZero Checklist (@sakluger)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1753898689311535104/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[sakluger]

Sent an offer to @fedirjh via Upwork. @fedirjh could you please complete the BZ checklist?

[fedirjh]

Sent an offer to @fedirjh via Upwork.

@sakluger I didn’t review the PR.

BugZero Checklist:

• Link to the PR: This is a regression from a new Live markdown feature.
• Link to comment: PR Author is aware and already handled it.
• Link to discussion: N/A
• Determine if we should create a regression test for this bug: This is a deploy blocker , we should have a regression test in place.

[sakluger]

@fedirjh confirmed that he is not due any payment on this issue, we're good to close out the issue.