Skip to content

[HOLD for payment 2024-03-07] [$500] [Simplified Collect][Categories] WorkspaceCategoriesSettingsPage: full page implementation - toggle require categories policy, onyx action #35706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
luacmartins opened this issue Feb 2, 2024 · 26 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Feb 2, 2024

Implement WorkspaceCategoriesSettingsPage: full page implementation - toggle require categories policy, onyx action from the Simplified Collect: Profile, Members, Categories design doc

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0154080d90e7f3dfba
  • Upwork Job ID: 1755659460840173568
  • Last Price Increase: 2024-02-08
  • Automatic offers:
    • cubuspl42 | Reviewer | 0
@luacmartins luacmartins added Engineering Daily KSv2 NewFeature Something to build that is a new item. labels Feb 2, 2024
@luacmartins luacmartins self-assigned this Feb 2, 2024
Copy link

melvin-bot bot commented Feb 2, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Feb 2, 2024
@luacmartins
Copy link
Contributor Author

@ArekChr can you please comment here so I can assign you to the issue?

@luacmartins luacmartins moved this to Release 1: Ideal Nav & Collect Simplfied Profile, Members, Categories, Workflows (approvals) in [#whatsnext] Wave 08 - Collect Plan Admins Feb 2, 2024
@luacmartins luacmartins changed the title WorkspaceCategoriesSettingsPage: full page implementation - toggle require categories policy, onyx action [Simplified Collect] [Categories] WorkspaceCategoriesSettingsPage: full page implementation - toggle require categories policy, onyx action Feb 2, 2024
@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 labels Feb 2, 2024
@luacmartins luacmartins changed the title [Simplified Collect] [Categories] WorkspaceCategoriesSettingsPage: full page implementation - toggle require categories policy, onyx action [Simplified Collect][Categories] WorkspaceCategoriesSettingsPage: full page implementation - toggle require categories policy, onyx action Feb 2, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 5, 2024
@ArekChr
Copy link
Contributor

ArekChr commented Feb 5, 2024

Sure, please assign me @luacmartins

Copy link

melvin-bot bot commented Feb 8, 2024

@luacmartins, @ArekChr, @lschurr Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Feb 8, 2024
@lschurr
Copy link
Contributor

lschurr commented Feb 8, 2024

Any update here @ArekChr?

@luacmartins luacmartins added the External Added to denote the issue can be worked on by a contributor label Feb 8, 2024
@melvin-bot melvin-bot bot changed the title [Simplified Collect][Categories] WorkspaceCategoriesSettingsPage: full page implementation - toggle require categories policy, onyx action [$500] [Simplified Collect][Categories] WorkspaceCategoriesSettingsPage: full page implementation - toggle require categories policy, onyx action Feb 8, 2024
Copy link

melvin-bot bot commented Feb 8, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0154080d90e7f3dfba

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 8, 2024
Copy link

melvin-bot bot commented Feb 8, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

@melvin-bot melvin-bot bot removed the Overdue label Feb 8, 2024
@luacmartins luacmartins removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 8, 2024
@melvin-bot melvin-bot bot added the Weekly KSv2 label Feb 23, 2024
@trjExpensify
Copy link
Contributor

With the PR in review, I'm taking this off hold.

@trjExpensify trjExpensify changed the title [Hold #35705] [$500] [Simplified Collect][Categories] WorkspaceCategoriesSettingsPage: full page implementation - toggle require categories policy, onyx action [$500] [Simplified Collect][Categories] WorkspaceCategoriesSettingsPage: full page implementation - toggle require categories policy, onyx action Feb 23, 2024
Copy link

melvin-bot bot commented Feb 26, 2024

📣 @cubuspl42 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

@luacmartins luacmartins assigned ArekChr and unassigned cubuspl42 Feb 26, 2024
Copy link

melvin-bot bot commented Feb 29, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Feb 29, 2024
@melvin-bot melvin-bot bot changed the title [$500] [Simplified Collect][Categories] WorkspaceCategoriesSettingsPage: full page implementation - toggle require categories policy, onyx action [HOLD for payment 2024-03-07] [$500] [Simplified Collect][Categories] WorkspaceCategoriesSettingsPage: full page implementation - toggle require categories policy, onyx action Feb 29, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 29, 2024
Copy link

melvin-bot bot commented Feb 29, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Feb 29, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.45-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-03-07. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Feb 29, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@allroundexperts] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@trjExpensify trjExpensify moved this to Release 1: Spring 2024 (May) in [#whatsnext] #wave-collect Mar 5, 2024
@lschurr
Copy link
Contributor

lschurr commented Mar 5, 2024

@allroundexperts - Could you review and confirm we don't need a regression test?

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Mar 7, 2024
Copy link

melvin-bot bot commented Mar 7, 2024

Payment Summary

Upwork Job

  • Contributor: @ArekChr is from an agency-contributor and not due payment
  • Reviewer: @allroundexperts owed $500 via NewDot

BugZero Checklist (@lschurr)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1755659460840173568/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@lschurr
Copy link
Contributor

lschurr commented Mar 7, 2024

I pulled back the contract offered in Upwork to Jakub T. since they didn't end up reviewing the PR - #37133 (comment)

@melvin-bot melvin-bot bot removed the Overdue label Mar 7, 2024
@lschurr
Copy link
Contributor

lschurr commented Mar 7, 2024

Payment summary is correct. Closing this one out.

@lschurr lschurr closed this as completed Mar 7, 2024
@github-project-automation github-project-automation bot moved this from Release 1: Spring 2024 (May) to Done in [#whatsnext] #wave-collect Mar 7, 2024
@JmillsExpensify
Copy link

$500 approved for @allroundexperts based on summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Projects
No open projects
Archived in project
Status: Release 1: Ideal Nav & Collect Simplfied Profile, Members, Categories, Workflows (approvals)
Development

No branches or pull requests

9 participants