[$1000] Jump to last unread chat when opening a report

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.28.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @MonilBhavsar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1705558628672569

Action Performed:

1. A is participant of a chat or room
2. As another user send some good number of messages to chat report, so new messages can be scrolled up and down
3. As user A, open the chat report

Expected Result:

The chat report view opens from where the messages are unread and user can scroll down

Actual Result:

The chat report view is scrolled down to the last message and user needs to scroll up to find last read message

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.5931.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fc144b2f2f5df388
• Upwork Job ID: 1749920553887232000
• Last Price Increase: 2024-06-11
• Automatic offers:
• ikevin127 | Contributor | 0
• ishpaul777 | Contributor | 102670752

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01fc144b2f2f5df388

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[jeremy-croff]

This PR #28793 specifically makes it scrolled to the bottom, seems like NAB

[trjExpensify]

I'm a bit confused by the bug report @MonilBhavsar, so asking about it here. I thought this was something we'd implement via comment linking.

[roryabraham]

HOLD for comment linking: #30269

[melvin-bot]

Current assignee @trjExpensify is eligible for the NewFeature assigner, not assigning anyone new.

[trjExpensify]

No change, still on hold Melv!

[trjExpensify]

Samesies, Melv!

[rlinoz]

Hey @janicduplessis any updates here?

[janicduplessis]

Sorry about the delay, I didn't end up having much time to work on this this week. It should be ready by early next week :)

[janicduplessis]

Still working on this, I hit a little issue where for some reason the first unread action is now wrong. It seems to be a regression since it happened after merging main. Trying to pinpoint what caused this.

[janicduplessis]

Good news, after updating to latest main the regression is gone. PR #51366 is now ready for review and further testing!

[rlinoz]

PR is being reviewed, looks like there is one outstanding bug reported here #51366 (comment)

[rlinoz]

@janicduplessis should be able to continue the work on the PR soon.

[rlinoz]

@chrispader took over while @janicduplessis is OOO, we are still ironing out some bugs.

[trjExpensify]

What's the latest here? We've had this issue/PR open a while at this point.

[rlinoz]

@chrispader can you give us an update here?

[chrispader]

I'm working on it right now. Basically the/a problem right now is, that when we have an unread report, then go offline, and then open the report, the messages and report will still be marked as read. This messes up the logic where we jump to the last unread message, once the user goes online and the rest of the messages loads.

I think i've found a potential solution, but still have to work on some edge-cases

[rlinoz]

PR is ready for a new review, we are looking whether there is a new bug or not.

[melvin-bot]

This issue has not been updated in over 15 days. @janicduplessis, @rlinoz, @trjExpensify, @ishpaul777 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[trjExpensify]

Looks like the PR is still in review. Also, not sure if this has been considered already, but you might want to test multi-expense reports with the tableReportView beta as that's super close to being released. CC: @Expensify/design @mountiny @luacmartins

[rlinoz]

Ah totally, @chrispader is fixing one more bug, and meanwhile I can test with the tableReportView

[shawnborton]

Good shout Tom!

[rlinoz]

@trjExpensify is the expected behavior that it always open at the first message?

[trjExpensify]

Might need to be a litttttle more specific man, haha. In what scenario? 😅

[rlinoz]

hahaha fair

in the tableReportView, given an expense report with multiple expenses and 100 comments, should it always open at the top showing the expenses of the report or at the last unread message?

[trjExpensify]

Gotcha! So yeah, if the expense report has an unread comment, we'd scroll to the unread comment. If not, the top of the report where the transaction table is in view.

I will say though, bugs like this where expense reports are unread because of rogue system messages make me a bit worried about applying this logic to expense reports. So it would be great to fix those once and for all. CC: @deetergp

[rlinoz]

@chrispader given the comment above, from what I was testing we are always opening at the top and load all the messages in between the unread and the oldest one. Can you also take a look at that, please?