[$500] [HOLD for payment 2023-12-28] [HOLD for payment 2023-12-26] [Theme Switching] 🐛 - App is still in dark mode when device dark mode is off #33101

lanitochka17 · 2023-12-14T17:50:02Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Version Number: 1.4.13.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition:

Device dark mode is on
App dark mode settings is set to "Use device settings"

Launch New Expensify app
Turn off dark mode

Expected Result:

App will switch to light mode

Actual Result:

The app is still in dark mode, even after relaunching the app

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6313358_1702574205482.Screen_Recording_20231214_235326_New_Expensify__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01325de77e255acbec
Upwork Job ID: 1743285192238567424
Last Price Increase: 2024-01-05

github-actions · 2023-12-14T17:50:19Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot · 2023-12-14T17:50:23Z

Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

melvin-bot · 2023-12-14T18:12:18Z

📣 @artus9033! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Make sure you've read and understood the contributing guidelines.
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

aldo-expensify · 2023-12-14T18:18:58Z

cc @grgia since you are the Theme expert I believe

aldo-expensify · 2023-12-14T18:20:21Z

This worked fine for me in Macos / Web. I'll try to test in Android

aldo-expensify · 2023-12-14T18:26:20Z

Reproduced in Android

grgia · 2023-12-14T18:31:50Z

Yes I believe we are hard coding this, I'm looking into it right now

aldo-expensify · 2023-12-14T18:34:53Z

Yes I believe we are hard coding this, I'm looking into it right now

Thanks, meanwhile I'm trying to install the latest version in the emulator to start debugging

grgia · 2023-12-14T18:36:23Z

#33090 here's some more context, but the PR up is not the full picture it still defaults to one theme currently

grgia · 2023-12-14T18:50:22Z

https://github.com/Expensify/App/pull/13874/files#diff-bc1549da6355f7f82f324af9c667b78ff60672b6b80219062629fe4184e8fa93R69-R70

Gonna test reverting these

grgia · 2023-12-14T18:56:53Z

It is important to note that remote debugging should be turned off, as when on it will always return "light". To turn on or off remote debugging type "d" on metro to open the menu on your device and then turn on/off remote debugging.

aldo-expensify · 2023-12-14T19:33:41Z

Still trying to test in emulators, android is getting stuck forever with info Starting JS server... and IOS is just giving the errors

error Error: Command failed with exit code 1: xcodebuild -list -json
xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance.
Error: Error: Command failed with exit code 1: xcodebuild -list -json
xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance
    at getProjectInfo (/Users/aldocanepa/Expensidev/App/node_modules/@react-native-community/cli-platform-ios/build/tools/getProjectInfo.js:29:11)
    at Object.runIOS [as func] (/Users/aldocanepa/Expensidev/App/node_modules/@react-native-community/cli-platform-ios/build/commands/runIOS/index.js:88:58)
    at Command.handleAction (/Users/aldocanepa/Expensidev/App/node_modules/@react-native-community/cli/build/index.js:111:23)
    at Command.listener [as _actionHandler] (/Users/aldocanepa/Expensidev/App/node_modules/@react-native-community/cli/node_modules/commander/lib/command.js:482:17)
    at /Users/aldocanepa/Expensidev/App/node_modules/@react-native-community/cli/node_modules/commander/lib/command.js:1283:65
    at Command._chainOrCall (/Users/aldocanepa/Expensidev/App/node_modules/@react-native-community/cli/node_modules/commander/lib/command.js:1177:12)
    at Command._parseCommand (/Users/aldocanepa/Expensidev/App/node_modules/@react-native-community/cli/node_modules/commander/lib/command.js:1283:27)
    at /Users/aldocanepa/Expensidev/App/node_modules/@react-native-community/cli/node_modules/commander/lib/command.js:1081:27
    at Command._chainOrCall (/Users/aldocanepa/Expensidev/App/node_modules/@react-native-community/cli/node_modules/commander/lib/command.js:1177:12)
    at Command._dispatchSubcommand (/Users/aldocanepa/Expensidev/App/node_modules/@react-native-community/cli/node_modules/commander/lib/command.js:1077:23)

💀

aldo-expensify · 2023-12-14T19:37:58Z

Oops, seems like I put xcode in the trash a month ago without realizing 🤦

aldo-expensify · 2023-12-14T20:56:44Z

Assigning @grgia since you fixed it! great work there :)

melvin-bot · 2023-12-19T01:56:06Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2023-12-19T01:56:08Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.13-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CPStaging] Fix Use Device Settings on IOS and Android #33094

If no regressions arise, payment will be issued on 2023-12-26. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@situchan requires payment (Needs manual offer from BZ)

melvin-bot · 2023-12-19T01:56:09Z

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@situchan] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
[@michaelhaxhiu] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

melvin-bot · 2023-12-21T05:06:59Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CPStaging] Fix Use Device Settings on IOS and Android #33094

If no regressions arise, payment will be issued on 2023-12-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@situchan requires payment (Needs manual offer from BZ)

melvin-bot · 2023-12-21T05:07:00Z

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@situchan] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
[@michaelhaxhiu] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

melvin-bot · 2023-12-28T11:33:16Z

@michaelhaxhiu, @grgia, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot · 2024-01-01T11:51:16Z

@michaelhaxhiu, @grgia, @situchan Still overdue 6 days?! Let's take care of this!

melvin-bot · 2024-01-01T17:47:54Z

@michaelhaxhiu, @grgia, @situchan 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

grgia · 2024-01-02T23:13:52Z

@michaelhaxhiu I think this one is just waiting on C+ review payment

michaelhaxhiu · 2024-01-05T14:54:57Z

Looking!

melvin-bot · 2024-01-05T14:55:55Z

Job added to Upwork: https://www.upwork.com/jobs/~01325de77e255acbec

melvin-bot · 2024-01-05T14:55:59Z

Current assignee @situchan is eligible for the External assigner, not assigning anyone new.

michaelhaxhiu · 2024-01-05T15:35:11Z

Offer sent - waiting to pay!

michaelhaxhiu · 2024-01-05T15:58:31Z

Done!

lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Dec 14, 2023

github-actions bot added Engineering Hourly KSv2 labels Dec 14, 2023

melvin-bot bot assigned aldo-expensify Dec 14, 2023

github-actions bot mentioned this issue Dec 14, 2023

Deploy Checklist: New Expensify 2023-12-14 #33072

Closed

77 tasks

melvin-bot bot mentioned this issue Dec 14, 2023

[HOLD for payment 2023-12-28] [HOLD for payment 2023-12-26] [Theme Switching] 🐛 "Use Device Settings" not working on IOS #33090

Closed

melvin-bot bot mentioned this issue Dec 14, 2023

[HOLD for payment 2023-01-11] [$2000] [Dark mode] Scrollbars should have a dark color #12914

Closed

grgia mentioned this issue Dec 14, 2023

[CPStaging] Fix Use Device Settings on IOS and Android #33094

Merged

52 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Dec 14, 2023

aldo-expensify assigned grgia and unassigned aldo-expensify Dec 14, 2023

grgia changed the title ~~Theme - App is still in dark mode when device dark mode is off~~ [Theme Switching] 🐛 - App is still in dark mode when device dark mode is off Dec 14, 2023

grgia added this to Theme Switching / Light Mode Dec 14, 2023

grgia assigned situchan Dec 18, 2023

github-actions bot mentioned this issue Dec 19, 2023

Deploy Checklist: New Expensify 2023-12-19 #33264

Closed

98 tasks

jasperhuangg removed the DeployBlockerCash This issue or pull request should block deployment label Dec 20, 2023

melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Dec 21, 2023

melvin-bot bot changed the title ~~[HOLD for payment 2023-12-26] [Theme Switching] 🐛 - App is still in dark mode when device dark mode is off~~ [HOLD for payment 2023-12-28] [HOLD for payment 2023-12-26] [Theme Switching] 🐛 - App is still in dark mode when device dark mode is off Dec 21, 2023

melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Dec 25, 2023

melvin-bot bot removed the Overdue label Jan 2, 2024

michaelhaxhiu added the External Added to denote the issue can be worked on by a contributor label Jan 5, 2024

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 5, 2024

michaelhaxhiu removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Jan 5, 2024

michaelhaxhiu closed this as completed Jan 5, 2024

github-project-automation bot moved this to Merged in Theme Switching / Light Mode Jan 5, 2024

[$500] [HOLD for payment 2023-12-28] [HOLD for payment 2023-12-26] [Theme Switching] 🐛 - App is still in dark mode when device dark mode is off #33101

[$500] [HOLD for payment 2023-12-28] [HOLD for payment 2023-12-26] [Theme Switching] 🐛 - App is still in dark mode when device dark mode is off #33101

Comments

lanitochka17 commented Dec 14, 2023 • edited by melvin-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

github-actions bot commented Dec 14, 2023

Uh oh!

melvin-bot bot commented Dec 14, 2023

Uh oh!

melvin-bot bot commented Dec 14, 2023

Uh oh!

aldo-expensify commented Dec 14, 2023

Uh oh!

aldo-expensify commented Dec 14, 2023

Uh oh!

aldo-expensify commented Dec 14, 2023

Uh oh!

grgia commented Dec 14, 2023

Uh oh!

aldo-expensify commented Dec 14, 2023

Uh oh!

grgia commented Dec 14, 2023

Uh oh!

grgia commented Dec 14, 2023

Uh oh!

grgia commented Dec 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aldo-expensify commented Dec 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aldo-expensify commented Dec 14, 2023

Uh oh!

aldo-expensify commented Dec 14, 2023

Uh oh!

melvin-bot bot commented Dec 19, 2023

Uh oh!

melvin-bot bot commented Dec 19, 2023

Uh oh!

melvin-bot bot commented Dec 19, 2023

Uh oh!

melvin-bot bot commented Dec 21, 2023

Uh oh!

melvin-bot bot commented Dec 21, 2023

Uh oh!

melvin-bot bot commented Dec 28, 2023

Uh oh!

melvin-bot bot commented Jan 1, 2024

Uh oh!

melvin-bot bot commented Jan 1, 2024

Uh oh!

grgia commented Jan 2, 2024

Uh oh!

michaelhaxhiu commented Jan 5, 2024

Uh oh!

melvin-bot bot commented Jan 5, 2024

Uh oh!

melvin-bot bot commented Jan 5, 2024

Uh oh!

michaelhaxhiu commented Jan 5, 2024

Uh oh!

michaelhaxhiu commented Jan 5, 2024

Uh oh!

lanitochka17 commented Dec 14, 2023 •

edited by melvin-bot bot

Loading

grgia commented Dec 14, 2023 •

edited

Loading

aldo-expensify commented Dec 14, 2023 •

edited

Loading