-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[HOLD for payment 2024-01-03] [DISTANCE] LOW: UpdateDistanceRequest 1:1:1 - UpdateMoneyRequestAmount - Split out into its own command #32316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Job added to Upwork: https://www.upwork.com/jobs/~013ac3360c28900621 |
Triggered auto assignment to Contributor Plus for review of internal employee PR - @akinwale ( |
Gonna continue to work on this today |
@akinwale, @luacmartins Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@akinwale, @luacmartins Still overdue 6 days?! Let's take care of this! |
1 similar comment
@akinwale, @luacmartins Still overdue 6 days?! Let's take care of this! |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.17-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-01-03. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
|
Triggered auto assignment to @miljakljajic ( |
There was regression |
Seems like the seven day hold for the regression is up - am I good to issue the 50% payment? |
Payment summary: @akinwale is owed $250 for their role reviewing this issue. Please request payment in NewDot. |
@miljakljajic I am not yet eligible for payment on NewDot. I still receive payments through Upwork. |
Apologies @akinwale - please accept the offer I just sent in Upwork. |
@miljakljajic Accepted. Thanks! |
Paid :) |
Uh oh!
There was an error while loading. Please reload this page.
There will be three pieces to this:
EditMoneyRequest
, create a new command calledUpdateMoneyRequestAmount
following the example in https://github.com/Expensify/Auth/pull/8986UpdateMoneyRequestAmount
following the example in https://github.com/Expensify/Web-Expensify/pull/39445Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @miljakljajicThe text was updated successfully, but these errors were encountered: