Skip to content

[HOLD for payment 2024-01-03] [DISTANCE] LOW: UpdateDistanceRequest 1:1:1 - UpdateMoneyRequestAmount - Split out into its own command #32316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #28358
tgolen opened this issue Nov 30, 2023 · 17 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Distance Wave5-free-submitters Engineering Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Weekly KSv2

Comments

@tgolen
Copy link
Contributor

tgolen commented Nov 30, 2023

There will be three pieces to this:

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013ac3360c28900621
  • Upwork Job ID: 1730344637166800896
  • Last Price Increase: 2023-11-30
Issue OwnerCurrent Issue Owner: @miljakljajic
@tgolen tgolen changed the title UpdateDistanceRequest 1:1:1 - UpdateRequestAmount - Split out into its own command [DISTANCE] LOW: UpdateDistanceRequest 1:1:1 - UpdateRequestAmount - Split out into its own command Nov 30, 2023
@tgolen tgolen added Distance Wave5-free-submitters Engineering Weekly KSv2 Internal Requires API changes or must be handled by Expensify staff labels Nov 30, 2023
Copy link

melvin-bot bot commented Nov 30, 2023

Job added to Upwork: https://www.upwork.com/jobs/~013ac3360c28900621

Copy link

melvin-bot bot commented Nov 30, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @akinwale (Internal)

@tgolen tgolen changed the title [DISTANCE] LOW: UpdateDistanceRequest 1:1:1 - UpdateRequestAmount - Split out into its own command [DISTANCE] LOW: UpdateDistanceRequest 1:1:1 - UpdateMoneyRequestAmount - Split out into its own command Nov 30, 2023
@luacmartins luacmartins self-assigned this Nov 30, 2023
@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 labels Nov 30, 2023
@melvin-bot melvin-bot bot added the Overdue label Dec 4, 2023
@luacmartins
Copy link
Contributor

Gonna continue to work on this today

@melvin-bot melvin-bot bot removed the Overdue label Dec 4, 2023
@luacmartins luacmartins added the Reviewing Has a PR in review label Dec 6, 2023
Copy link

melvin-bot bot commented Dec 14, 2023

@akinwale, @luacmartins Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Dec 18, 2023

@akinwale, @luacmartins Still overdue 6 days?! Let's take care of this!

1 similar comment
Copy link

melvin-bot bot commented Dec 18, 2023

@akinwale, @luacmartins Still overdue 6 days?! Let's take care of this!

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Dec 19, 2023
Copy link

melvin-bot bot commented Dec 26, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Dec 27, 2023
@melvin-bot melvin-bot bot changed the title [DISTANCE] LOW: UpdateDistanceRequest 1:1:1 - UpdateMoneyRequestAmount - Split out into its own command [HOLD for payment 2024-01-03] [DISTANCE] LOW: UpdateDistanceRequest 1:1:1 - UpdateMoneyRequestAmount - Split out into its own command Dec 27, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 27, 2023
Copy link

melvin-bot bot commented Dec 27, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Dec 27, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.17-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-01-03. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

  • @akinwale requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented Jan 5, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Overdue Daily KSv2 labels Jan 5, 2024
@situchan
Copy link
Contributor

situchan commented Jan 5, 2024

There was regression

@miljakljajic
Copy link
Contributor

Seems like the seven day hold for the regression is up - am I good to issue the 50% payment?

@miljakljajic
Copy link
Contributor

Payment summary:

@akinwale is owed $250 for their role reviewing this issue. Please request payment in NewDot.

@github-project-automation github-project-automation bot moved this from Release 5: Best in Class to Done in [#whatsnext] Wave 05 - Deprecate Free Jan 10, 2024
@akinwale
Copy link
Contributor

Payment summary:

@akinwale is owed $250 for their role reviewing this issue. Please request payment in NewDot.

@miljakljajic I am not yet eligible for payment on NewDot. I still receive payments through Upwork.

@mountiny mountiny reopened this Jan 16, 2024
@miljakljajic
Copy link
Contributor

Apologies @akinwale - please accept the offer I just sent in Upwork.

@akinwale
Copy link
Contributor

@miljakljajic Accepted. Thanks!

@miljakljajic
Copy link
Contributor

Paid :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Distance Wave5-free-submitters Engineering Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

6 participants