Skip to content

[Snyk] Security upgrade electron from 25.8.2 to 25.9.4 #31123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
melvin-bot bot opened this issue Nov 9, 2023 · 5 comments
Closed

[Snyk] Security upgrade electron from 25.8.2 to 25.9.4 #31123

melvin-bot bot opened this issue Nov 9, 2023 · 5 comments
Assignees
Labels
Internal Requires API changes or must be handled by Expensify staff Monthly KSv2

Comments

@melvin-bot
Copy link

melvin-bot bot commented Nov 9, 2023

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • package.json
    • package-lock.json

Vulnerabilities that will be fixed

With an upgrade:
Severity Issue Breaking Change Exploit Maturity
high severity Improper Input Validation
SNYK-JS-ELECTRON-6043905
No No Known Exploit
high severity Integer Overflow or Wraparound
SNYK-JS-ELECTRON-6043907
No No Known Exploit

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Improper Input Validation

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01eaf20d851420644a
  • Upwork Job ID: 1722609692504813568
  • Last Price Increase: 2023-11-09
@melvin-bot melvin-bot bot added Internal Requires API changes or must be handled by Expensify staff Weekly KSv2 labels Nov 9, 2023
Copy link
Author

melvin-bot bot commented Nov 9, 2023

This is a Snyk issue. Snyk is a tool that automatically tracks our repositories' dependencies and reports associated security vulnerabilities. It also automatically create PRs to fix these vulnerabilities.

    C+: Please follow these steps to test the linked PR before running through the reviewer checklist:
    - [ ] The first step is to understand the PR: what dependency is it upgrading, for which vulnerability, how it impacts our product & end users.
    - [ ] If the issue is not worth fixing, please add your reasoning in the issue and have the internal engineer review it.
    - [ ] Check the change log (which should be included in the PR description) to see all changes. We want to identify any breaking changes. If it is a minor version bump, it's unlikely that there are any breaking changes.
    - [ ] Test our feature(s) that make use of this package. If it does not work, we should understand what broke it. It is also a good idea to check our main flows to make sure they are not broken that you can add in the checklist screenshots/videos.

Copy link
Author

melvin-bot bot commented Nov 9, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01eaf20d851420644a

Copy link
Author

melvin-bot bot commented Nov 9, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @akinwale (Internal)

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Dec 4, 2023
Copy link
Author

melvin-bot bot commented Dec 4, 2023

This issue has not been updated in over 15 days. @akinwale eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@rlinoz
Copy link
Contributor

rlinoz commented Dec 6, 2023

Closing since the PR is merged

@rlinoz rlinoz closed this as completed Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Requires API changes or must be handled by Expensify staff Monthly KSv2
Projects
None yet
Development

No branches or pull requests

2 participants