Skip to content

[HOLD for payment 2023-12-26] [DISTANCE] LOW: UpdateDistanceRequest 1:1:1 - UpdateMoneyRequestDate - Split out into its own command #29993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #28358
tgolen opened this issue Oct 19, 2023 · 32 comments
Closed
Tracked by #28358

[HOLD for payment 2023-12-26] [DISTANCE] LOW: UpdateDistanceRequest 1:1:1 - UpdateMoneyRequestDate - Split out into its own command #29993

tgolen opened this issue Oct 19, 2023 · 32 comments
Assignees
@JmillsExpensify @tgolen @ArekChr
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Distance Wave5-free-submitters Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@tgolen
Copy link
Contributor

tgolen commented Oct 19, 2023 •
edited
Loading

There will be three pieces to this:

This will all be done internally as they are refactored.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019eb683577f4e3784
  • Upwork Job ID: 1715033771434577920
  • Last Price Increase: 2023-10-19
Issue OwnerCurrent Issue Owner: @JmillsExpensify
@tgolen tgolen mentioned this issue Oct 19, 2023
Closed
9 tasks
@tgolen tgolen self-assigned this Oct 19, 2023
@tgolen tgolen added Engineering Daily KSv2 Internal Requires API changes or must be handled by Expensify staff labels Oct 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2023

Job added to Upwork: https://www.upwork.com/jobs/~019eb683577f4e3784

@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @ArekChr (Internal)

@tgolen tgolen changed the title UpdateRequestDate EditDistanceRequest 1:1:1 - UpdateRequestDate - Split out into its own command Oct 19, 2023
@tgolen
Copy link
Contributor Author

tgolen commented Oct 19, 2023

Got started on the auth command today and put up a WIP. I also asked in Slack about how to go about a testing strategy for all these commands.

@tgolen tgolen changed the title EditDistanceRequest 1:1:1 - UpdateRequestDate - Split out into its own command UpdateDistanceRequest 1:1:1 - UpdateRequestDate - Split out into its own command Oct 20, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 23, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 23, 2023

@tgolen, @ArekChr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot
Copy link

melvin-bot bot commented Oct 25, 2023

@tgolen, @ArekChr Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot
Copy link

melvin-bot bot commented Oct 27, 2023

@tgolen, @ArekChr 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@tgolen
Copy link
Contributor Author

tgolen commented Oct 27, 2023

I will be able to get started on this again on Monday.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 27, 2023
@tgolen
Copy link
Contributor Author

tgolen commented Oct 30, 2023

I am hoping to get started on this today.

@melvin-bot melvin-bot bot removed the Overdue label Oct 30, 2023
@tgolen
Copy link
Contributor Author

tgolen commented Oct 31, 2023

Yesterday I was able to write 90% of the auth PR. The only thing left I need to do is write and return the Onyx updates. I also wrote 95% of the web-e PR and 90% of the app PRs. Today, I am hoping to complete the full flow so that I can begin testing and fine-tuning the solution.

@tgolen
Copy link
Contributor Author

tgolen commented Nov 1, 2023

Draft PRs:
#30737
https://github.com/Expensify/Web-Expensify/pull/39445
https://github.com/Expensify/Auth/pull/8986

@tgolen tgolen added Weekly KSv2 and removed Daily KSv2 labels Nov 2, 2023
@tgolen
Copy link
Contributor Author

tgolen commented Nov 2, 2023

I'm dropping this back down to weekly while I try to finish up this PR that came off HOLD.

@tgolen
Copy link
Contributor Author

tgolen commented Nov 3, 2023

I got all the changes done in the App PR today. Now I need to revisit both Web-E and Auth and finish up those PRs. They are mainly missing code to return OnyxUpdates to the frontend. Then, testing will commence.

@dylanexpensify dylanexpensify changed the title UpdateDistanceRequest 1:1:1 - UpdateRequestDate - Split out into its own command [DISTANCE] LOW:UpdateDistanceRequest 1:1:1 - UpdateRequestDate - Split out into its own command Nov 7, 2023
@dylanexpensify dylanexpensify changed the title [DISTANCE] LOW:UpdateDistanceRequest 1:1:1 - UpdateRequestDate - Split out into its own command [DISTANCE] LOW: UpdateDistanceRequest 1:1:1 - UpdateRequestDate - Split out into its own command Nov 7, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 14, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Dec 19, 2023
@melvin-bot melvin-bot bot changed the title [DISTANCE] LOW: UpdateDistanceRequest 1:1:1 - UpdateMoneyRequestDate - Split out into its own command [HOLD for payment 2023-12-26] [DISTANCE] LOW: UpdateDistanceRequest 1:1:1 - UpdateMoneyRequestDate - Split out into its own command Dec 19, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 19, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 19, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 19, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.13-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-26. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

  • @ArekChr does not require payment (Contractor)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Dec 25, 2023
@tgolen
Copy link
Contributor Author

tgolen commented Dec 26, 2023

I think this can be closed out since it doesn't look like it requires payment.

@tgolen tgolen closed this as completed Dec 26, 2023
@cubuspl42
Copy link
Contributor

@tgolen I was the C+ reviewer

@tgolen
Copy link
Contributor Author

tgolen commented Dec 27, 2023

Reopening to get the C+ reviewer paid 👍

@tgolen tgolen reopened this Dec 27, 2023
@tgolen tgolen added the Bug Something is broken. Auto assigns a BugZero manager. label Dec 27, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 27, 2023

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot Melvin Bot

This comment was marked as off-topic.

Sign in to view
@tgolen
Copy link
Contributor Author

tgolen commented Dec 27, 2023

@JmillsExpensify Can you please pay @cubuspl42 for their C+ review of the PR?

@melvin-bot melvin-bot bot added the Overdue label Jan 1, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jan 1, 2024

@JmillsExpensify, @tgolen, @ArekChr Huh... This is 4 days overdue. Who can take care of this?

@JmillsExpensify
Copy link

Do we need to add any regression tests for this? Assuming no given that it's a backend refactor.

@melvin-bot melvin-bot bot removed the Overdue label Jan 3, 2024
@JmillsExpensify
Copy link

Payment summary: $500 to @cubuspl42 for PR testing and review.

@JmillsExpensify
Copy link

Offer sent!

@cubuspl42
Copy link
Contributor

Accepted

@JmillsExpensify
Copy link

All paid out. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JmillsExpensify JmillsExpensify

@tgolen tgolen

@ArekChr ArekChr

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Distance Wave5-free-submitters Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
No open projects
[#whatsnext] Wave 05 - Deprecate Free
Status: Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@JmillsExpensify @tgolen @cubuspl42 @ArekChr @dylanexpensify