[HOLD for payment 2023-10-02] Chat - IOU - Hover is not being shown after stopping to scroll

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open a chat where there are IOU cards and scrollable conversation
2. Scroll and stop in the middle of an IOU card
3. Move the mouse horizontally on the IOU card without moving up and down to hover over other components

Expected Result:

There should be a hover indicator and context menu should show up just after stopping scrolling even if user doesn't move the mouse up and down

Actual Result:

Hover indicator and context menu doesn't show up unless user hovers over other components and comes back

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.72-6

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

2023-09-20.17.15.27.mp4

Recording.1565.mp4

Expensify/Expensify Issue URL:

Issue reported by: @Nathan-Mulugeta

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695219522514479

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[raymondchooi]

Proposal

Scroll while still hovering over component hides existing reaction/hover

What is the root cause of that problem?

isHoveredRef is set to false on scroll start and on scroll stop the state is set to isHoveredRef which is false

What changes do you think we should make in order to solve the problem?

Remove this line:

App/src/components/Hoverable/index.js

Line 49 in d00a4d6

this.isHoveredRef = false;

The hover state is still set to false on scroll in the line below but the previous hover state can be set again if the original component is still hovered:

App/src/components/Hoverable/index.js

Line 50 in d00a4d6

this.setState({isHovered: false}, this.props.onHoverOut);

What alternative solutions did you explore?

A timeout could be applied to handle when hover state should be checked again after scroll stop

[raymondchooi]

@Pluto0104 If you hover over a component and scroll a little bit while still hovering over the component, the hover effect disappears.

In Slack the hover effect is invisible while scrolling but becomes visible again when stopped on scrolling on the same component (Slack was referenced in that PR issue as an optimal behaviour)

[Nathan-Mulugeta]

+1 on @raymondchooi's comment

[tylerkaraszewski]

It looks like we may have broken this here: #27236

@mountiny @abdulrahuman5196 do you have any ideas?

[mountiny]

@thienlnam i think this does not have to be a blocker, seems quite minor and could go through a normal deploy process, do you agree? @hurali97 could you look into fixing this one?

[thienlnam]

Yeah I agree, looks pretty minor

[hurali97]

@mountiny Yeah sure, I am looking into this !

[melvin-bot]

📣 @hurali97! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.73-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: hover not shown when scroll on same item #27921

If no regressions arise, payment will be issued on 2023-10-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @abdulrahuman5196 requires payment
• @hurali97 requires payment
• @Nathan-Mulugeta requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
• [@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@abdulrahuman5196] Determine if we should create a regression test for this bug.
• [@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mollfpr]

@mountiny @adelekennedy Could you guys help assign me here? Thanks!

[mollfpr]

[@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
[@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

#27236

[@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

The regression step should be good.

[@abdulrahuman5196] Determine if we should create a regression test for this bug.
[@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1. Go to any Report and start scrolling.
2. Once the scroll stops on an item, the hover effect should be visible.
3. Scroll slightly to remain in that item.
4. Verify the hover effect should disappear when you scroll and should come back when you stop.
5. 👍 or 👎

[adelekennedy]

@mountiny @thienlnam what's the deal here - #27236 so is anyone due payment (I'm searching stack overflow and coming up short)

[mountiny]

@adelekennedy its $500 to @mollfpr for reviewing and testing #27921

And then @Nathan-Mulugeta $50 for reporting this issue

[adelekennedy]

Offer sent to @mollfpr and @Nathan-Mulugeta here

[mollfpr]

@adelekennedy I think I can get paid from NewDot from now on. Confirm in #27087 (comment).

[JmillsExpensify]

Can I get a payment summary on this issue so I can issue payment for @mollfpr?

[mountiny]

@JmillsExpensify summary is

• @mollfpr $500 for review and testing
• @Nathan-Mulugeta $50 for reporting

[JmillsExpensify]

$500 payment approved for @mollfpr based on summary above.