Skip to content

[$500] [HOLD for payment 2023-12-07] [TS migration] Migrate 'ExpensifyWordmark.js' component to TypeScript #25084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 18 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/ExpensifyWordmark.js 15
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01affad6b31372ce99
  • Upwork Job ID: 1734173286632579072
  • Last Price Increase: 2023-12-11
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@VickyStash
Copy link
Contributor

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

Copy link
Author

melvin-bot bot commented Nov 20, 2023

Triggered auto assignment to @Julesssss, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 24, 2023
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'ExpensifyWordmark.js' component to TypeScript [HOLD for payment 2023-12-07] [TS migration] Migrate 'ExpensifyWordmark.js' component to TypeScript Nov 30, 2023
Copy link
Author

melvin-bot bot commented Nov 30, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 30, 2023
Copy link
Author

melvin-bot bot commented Nov 30, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.5-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Dec 7, 2023
@fedirjh
Copy link
Contributor

fedirjh commented Dec 8, 2023

@Julesssss Can you please assign me this issue so I can track C+ payment for #31824? Thank you.

@melvin-bot melvin-bot bot added the Overdue label Dec 11, 2023
@Julesssss Julesssss added External Added to denote the issue can be worked on by a contributor Bug Something is broken. Auto assigns a BugZero manager. labels Dec 11, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-12-07] [TS migration] Migrate 'ExpensifyWordmark.js' component to TypeScript [$500] [HOLD for payment 2023-12-07] [TS migration] Migrate 'ExpensifyWordmark.js' component to TypeScript Dec 11, 2023
Copy link
Author

melvin-bot bot commented Dec 11, 2023

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link
Author

melvin-bot bot commented Dec 11, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01affad6b31372ce99

@melvin-bot melvin-bot bot added Help Wanted Apply this label when an issue is open to proposals by contributors and removed Overdue labels Dec 11, 2023
Copy link
Author

melvin-bot bot commented Dec 11, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Copy link
Author

melvin-bot bot commented Dec 11, 2023

Current assignee @fedirjh is eligible for the External assigner, not assigning anyone new.

@Julesssss
Copy link
Contributor

Hey @abekkala, would you mind paying out @fedirjh for a C+ review? Thank you!

@abekkala
Copy link
Contributor

@Julesssss Yes - can I confirm that this TS Migration payment was raised to $500 vs. the standard $250?

@Julesssss
Copy link
Contributor

I believe the C+ reviewer price should be $500, but please let me know if that is incorrect @fedirjh

@fedirjh
Copy link
Contributor

fedirjh commented Dec 11, 2023

@Julesssss As per this discussion https://expensify.slack.com/archives/C02NK2DQWUX/p1696095974964599 it should be 250$.

@Julesssss
Copy link
Contributor

Ah thank you, I was struggling to find that update 👍

@abekkala
Copy link
Contributor

@fedirjh I've sent the Upwork offer here

@fedirjh
Copy link
Contributor

fedirjh commented Dec 12, 2023

Thank you @abekkala accepted.

@abekkala
Copy link
Contributor

@fedirjh payment sent and contract ended - thank you! 🎉

@github-project-automation github-project-automation bot moved this from Todo to Done in Typescript migration Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Task Typescript Migration
Projects
No open projects
Development

No branches or pull requests

4 participants