[HOLD for payment 2023-10-02] [HOLD for payment 2023-09-27] [Wave 6: Categories] CRITICAL: Allow Editing a Category on a Money Request

[puneetlath]

Tracking Issue: https://github.com/Expensify/Expensify/issues/282161

Design Doc: https://docs.google.com/document/d/1itXKWlhms5YHcF4-lujO6g8T5LPdLVD_7onjtZBsATQ/edit#

HOLD ON https://github.com/Expensify/Expensify/issues/302031

---

Viewing Categories on Money Requests

For viewing a category on an already existing Money Request, if isSingleTransactionView = true, we'll render a MenuItemWithTopDescription in the MoneyRequestView. (This is not too different from what we do for the MoneyRequestConfirmationList above when creating an expense).

• This menu item component will display the category tied to the expense.
• If there are no categories on the policy AND there is no category already on the expense, then the component will not display.

If a request is paid, then users will not be able to tap the request to edit the category, unless they are an admin of the policy the request is on.

• We can check if someone is an admin of a policy by calling PolicyUtils.isPolicyAdmin.

Editing Categories on Money Requests

To edit, we will be building off the EditMoneyRequestPage added in Wave 3: Manual Requests. We'll add a new route to the moneyRequestDetails Form that will render our CategoryPicker described above.

// src/pages/iou/EditMoneyRequestPage.js

<Form
  formID='moneyRequestDetails'
  validate={this.validate}
  onSubmit={this.onSubmit}
>

    // ... Other routes and their edit paths

    ) ? route === 'category' (
      <CategoryPicker
        inputID="category"
        label="Category"
        placeholder={props.translate('common.category')}
      />
    )
</Form>

The component will work the same as it does in the Money Request creation flow, except this time the onSubmit prop function will call the UpdateTransaction API command. The action is described in Wave 3: Manual Requests. We will update it to support changing the category.

A couple of other notes about editing categories:

• If you are offline, we will not actually call the UpdateTransaction API command but use the optimisticData of the UpdateTransaction API.write call to display your category in a "greyed out" state. When the update syncs with the server we'll "ink in" the change.
• If a category is disabled, but was already selected on a Money Request, when the user clicks the category to edit it, the disabled but selected category will show in the "Selected Category" section. Unselecting it will make it disappear since the user will be navigated back to the expense, saving an empty category on it.
  • Should they open the list again, because the category was disabled, they will not be able to see it to re-select it.
  • The same would apply if there were < 8 categories on the policy. We would just show the selected category directly in the list of categories itself.
• If categories are completely disabled, or there are no enabled categories on the policy, but there is a category on an expense…
  • When the user clicks the category to edit it, the lone category will be shown as the only category in the policy.
  • This will use the "simplified" < 8 categories view.
  • Deselecting the category will again navigate the user back to the expense.
  • This time, because there are no categories on the policy and no category is selected, the Category menu item will disappear.

[melvin-bot]

Triggered auto assignment to @sakluger (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

[rezkiy37]

Hi, I'm Michael (Mykhailo) from Callstack and I would like to work in this issue.

[waterim]

Hello, Im Artem from Callstack and I would like to help with this issue

[puneetlath]

This is still on hold.

[yuwenmemon]

Still on HOLD

[yuwenmemon]

Also, another development, because we want to start sending push notifications for category updates from our server before this goes live, we can no longer rely on the absence of categories to hide the selector from the EditRequestPage. We'll need to check that a user is on a beta in addition to that.

This means we'll need to add a canUseCategories to the Permissions.js file, and check that before showing the selector or not. Does that make sense / sound good?

[rezkiy37]

Waiting on backend, because it is important to test and verify that the app handles everything properly.

[yuwenmemon]

Actually, @rezkiy37 we need to deploy the front-end portion first because of the way EditMoneyRequest works. Right now, if it doesn't see a category coming from the client it will clear the category entirely (cc @mountiny). Would you be able to build out the front-end portions - sending the category as a param to EditMoneyRequest into the ether - and then we can test and verify things work well from there? This is all under a beta so we should be safe to do so.

[rezkiy37]

Actually, @rezkiy37 we need to deploy the front-end portion first because of the way EditMoneyRequest works. Right now, if it doesn't see a category coming from the client it will clear the category entirely (cc @mountiny). Would you be able to build out the front-end portions - sending the category as a param to EditMoneyRequest into the ether - and then we can test and verify things work well from there? This is all under a beta so we should be safe to do so.

Makes sense. I agree. I am preparing a PR today.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.71-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Attach reportID to IOU when requesting from the global flow #27139

If no regressions arise, payment will be issued on 2023-09-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @waterim does not require payment (Contractor)
• @rezkiy37 does not require payment (Contractor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[rezkiy37]

Melvin, this issue is not completed yet. The main PR - #27459 - still under review.

[rezkiy37]

The PR - #27459 - has been merged.

[puneetlath]

Looks like no C+ payment is required for this issue. So we can go ahead and close it out once it's on production.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.73-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Allow Viewing/Editing a category on a Money Request #27459

If no regressions arise, payment will be issued on 2023-10-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @waterim does not require payment (Contractor)
• @rezkiy37 does not require payment (Contractor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty