[HOLD for payment 2023-08-28] [ECard Settings] Clean up cardList in Onyx [Step 4]

[grgia]

DD Section

https://docs.google.com/document/d/1rFxJ78vz5On6zSWzYa51B9v-tyLdC5pUsBeLOLig0t4/edit#bookmark=id.fg7t78w4i1po

Step

4. Update E/App Add new Onyx key for Expensify Card data, CORPORATE_CARD_LIST

[melvin-bot]

Triggered auto assignment to @trjExpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

[grgia]

I don't have the PR up for this one yet, should be a really easy one though and could be done now

[trjExpensify]

Cool, presumably are we handling that internally? If so, I can add the Internal label.

[melvin-bot]

@trjExpensify, @grgia Whoops! This issue is 2 days overdue. Let's get this updated quick!

[trjExpensify]

No change, Georgia is out.

[trjExpensify]

@grgia now you're back, can I confirm this needs an internal label and you're taking on the implementation?

[grgia]

Yes this is internal, but no C+ is required because there will be no QA or tests for this PR

[grgia]

PR merged

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.55-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [NO QA] [Step 4] Add CORPORATE_CARD_LIST key #24641

If no regressions arise, payment will be issued on 2023-08-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[trjExpensify]

So I think we can just close this, yeah @grgia? Feel free to reopen if I missed something!