[HOLD for payment 2023-08-28] [$1000] Dev: Web - Emoji-reacted tooltip does not close for User B when User A deletes the message #23308
Comments
kbecciv
added
Daily
|
Triggered auto assignment to @dylanexpensify ( |
Bug0 Triage Checklist (Main S/O)
|
|
This bug might be regression of this PR |
|
This issue will be fixed by this proposal. |
|
@StevenKKC Root case of the both is not same right? |
|
@ayazhussain79 The root cause of this issue is that showing incorrect tooltip, so tooltip does not close automatically. |
|
Reviewing today! |
|
Agree @StevenKKC |
|
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
|
@dylanexpensify This bug is still reproducible and PR merged |
|
@dylanexpensify Reopening this as have other cases being reported of this, and this one is the earliest case 👍 |
|
@CortneyOfstad Thank you |
ProposalPlease re-state the problem that we are trying to solve in this issue.Emoji-reacted tooltip does not close for User B when User A deletes the message. What is the root cause of that problem?The root cause is What changes do you think we should make in order to solve the problem?We should check whether the report action is deleted in
<PopoverReactionList ref={context.reactionListRef} reportID={props.report.reportID} />
reactionListRef.current.showReactionList(event, popoverReactionListAnchor.current, reaction, props.reportActionID);
- showReactionList(event, reactionListAnchor, emojiReaction) {
+ showReactionList(event, reactionListAnchor, emojiReaction, reportActionID) {
...
this.getReactionListMeasuredLocation().then(({x, y}) => {
this.setState({
...
+ reportActionID,
});
});
}
shouldComponentUpdate(nextProps, nextState) {
...
+ if (this.props.reportID && this.state.reportActionID) {
+ const reportAction = ReportActionsUtils.getReportAction(this.props.reportID, this.state.reportActionID);
+ const isDeletedAction = ReportActionsUtils.isDeletedAction(reportAction);
+ if (isDeletedAction && this.state.isPopoverVisible) {
+ this.hideReactionList();
+ return true;
+ }
+ }
return (
...
);
}
const propTypes = {
/** The report currently being looked at */
reportID: PropTypes.string.isRequired,
...withLocalizePropTypes,
};
...
PopoverReactionList.propTypes = propTypes;
constructor(props) {
super(props);
this.state = {
...
reportActionID: '',
};What alternative solutions did you explore? (Optional)None. |
|
@ayazhussain79 Sorry for confusion. I said that my proposal will fix this issue, but my proposal does not accepted. |
|
reviewing today! |
dylanexpensify
added
the
External
melvin-bot
bot
changed the title
|
Job added to Upwork: https://www.upwork.com/jobs/~01974ea524eb1b8de8 |
|
🎯 ⚡️ Woah @fedirjh / @hoangzinh, great job pushing this forwards! ⚡️ The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉
On to the next one 🚀 |
|
Nice one!! |
melvin-bot
bot
added
Weekly
melvin-bot
bot
changed the title
|
|
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.55-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-08-28. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
|
Payment coming next week! |
|
Woot! Let's get it - Payment Summary:
Upwork Job! Please apply! |
|
@dylanexpensify applied on upwork, Thank you |
|
Paying out now! |
|
Payments sent! @ayazhussain79 offer sent! |
|
@dylanexpensify offer accepted, Thank you |
|
Done! @fedirjh can you complete checklist please? |
BugZero Checklist:
Regression Test Proposal
Do we agree 👍 or 👎 |
|
Looks good! |
Uh oh!
There was an error while loading. Please reload this page.
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
Expected Result:
The emoji-reacted tooltip should close for User B's account when User A deletes the message
Actual Result:
The emoji-reacted tooltip remains open for User B's account even after the message is deleted
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: Dev 1.3.43-2
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
screen-recording-2023-07-20-at-53117-pm_FLVKk5W6.1.mp4
Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689857009202199
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: