Skip to content

Chat - Back button brings to thread chat instead of LHN after clicking parent chat link in header #20851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 6 tasks
lanitochka17 opened this issue Jun 15, 2023 · 4 comments
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Jun 15, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue found when executing PR #20484

Action Performed:

  1. Login to NewDot
  2. Open chat
  3. Send message
  4. Create a thread
  5. Tap parent link in the header
  6. Parent chat is displayed
  7. Tap back button

Expected Result:

LHN should be displayed

Actual Result:

Thread chat is displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.28.3

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6094477_video_58__1_.1.mp4
Bug6094477_video_59__1_.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Jun 15, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jun 15, 2023

Triggered auto assignment to @chiragsalian (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@chiragsalian
Copy link
Contributor

I'm pretty sure this is not a blocker, back button by design takes you to the previous screen. If your thread was the previous screen then it would take you to the thread. By design it would work the same on any mobile screen.

I'll ask around and confirm if people want the behavior to be different.

@chiragsalian
Copy link
Contributor

Verified with @JmillsExpensify, this is by design. The back button goes to the previous screen in the stack. Closing since this is a non-issue.

@github-actions github-actions bot removed the DeployBlockerCash This issue or pull request should block deployment label Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants