-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[HOLD] Chat - Link preview does not appear except google.com #20832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @flodnv ( |
Not a blocker because it's a brand new feature, discussed here: https://expensify.slack.com/archives/C01GTK53T8Q/p1686845846653239?thread_ts=1686840921.260039&cid=C01GTK53T8Q |
Job added to Upwork: https://www.upwork.com/jobs/~0139a876cca4721bb4 |
Triggered auto assignment to Contributor Plus for review of internal employee PR - @fedirjh ( |
Not a deploy blocker. |
Triggered auto assignment to @joekaufmanexpensify ( |
@wojtus7 I will check the backend for this to see if we need a change there or if there's some other reason this is not working. |
Oh yes the soft limit is only 50 requests per day LOL we would break that in 0.00001 seconds. |
Still on my list to look into. |
Still setting up the accounts. |
@marcaaron we're not now seeing link previews for other sites except google. Seems like this issue is fixed? cc @hungvu193 |
Hmm can you clarify what exactly you are seeing? Like what platform are you testing on? Show me what you did? To give an update - the rate limiting issue should be fixed now. But we might have CSP issues to look into on web since we are loading images and content that are outside our domain. |
I think we can close this one out then? |
Uh oh!
There was an error while loading. Please reload this page.
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Issue found when executing PR #17288
Action Performed:
Expected Result:
Link preview appears
Actual Result:
Link preview does not appear except google.com
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.28.3
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug6094139_17288_-_web.mp4
Expensify/Expensify Issue URL:
Issue reported by: Appause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: