Skip to content

[HOLD] Chat - Link preview does not appear except google.com #20832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
6 tasks done
lanitochka17 opened this issue Jun 15, 2023 · 16 comments
Closed
6 tasks done

[HOLD] Chat - Link preview does not appear except google.com #20832

lanitochka17 opened this issue Jun 15, 2023 · 16 comments
Assignees
Labels
Engineering Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Jun 15, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue found when executing PR #17288

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Go to any chat
  3. Send any link

Expected Result:

Link preview appears

Actual Result:

Link preview does not appear except google.com

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.28.3

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6094139_17288_-_web.mp4

Expensify/Expensify Issue URL:

Issue reported by: Appause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0139a876cca4721bb4
  • Upwork Job ID: 1669387928143917056
  • Last Price Increase: 2023-06-15
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Jun 15, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jun 15, 2023

Triggered auto assignment to @flodnv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@flodnv
Copy link
Contributor

flodnv commented Jun 15, 2023

Not a blocker because it's a brand new feature, discussed here: https://expensify.slack.com/archives/C01GTK53T8Q/p1686845846653239?thread_ts=1686840921.260039&cid=C01GTK53T8Q

@marcaaron marcaaron added Weekly KSv2 Internal Requires API changes or must be handled by Expensify staff and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jun 15, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 15, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0139a876cca4721bb4

@marcaaron marcaaron self-assigned this Jun 15, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 15, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @fedirjh (Internal)

@marcaaron
Copy link
Contributor

Not a deploy blocker.

@marcaaron marcaaron added the NewFeature Something to build that is a new item. label Jun 15, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 15, 2023

@marcaaron
Copy link
Contributor

marcaaron commented Jun 15, 2023

@wojtus7 I will check the backend for this to see if we need a change there or if there's some other reason this is not working.

@marcaaron
Copy link
Contributor

Hmm so on first blush... this is working for me fine locally.

2023-06-15_07-19-15

But the behavior is different on staging 🤔 which makes me think that we are just getting rate limited as we are still testing on the free tier usage. For now, I will add some more logs.

@marcaaron
Copy link
Contributor

Oh yes the soft limit is only 50 requests per day LOL we would break that in 0.00001 seconds.

@melvin-bot melvin-bot bot added the Overdue label Jun 23, 2023
@marcaaron
Copy link
Contributor

Still on my list to look into.

@melvin-bot melvin-bot bot added the Overdue label Jul 4, 2023
@marcaaron
Copy link
Contributor

Still setting up the accounts.

@melvin-bot melvin-bot bot removed the Overdue label Jul 4, 2023
@marcaaron marcaaron changed the title Chat - Link preview does not appear except google.com [HOLD] Chat - Link preview does not appear except google.com Jul 4, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 13, 2023
@MonilBhavsar
Copy link
Contributor

@marcaaron we're not now seeing link previews for other sites except google. Seems like this issue is fixed? cc @hungvu193

@marcaaron
Copy link
Contributor

Hmm can you clarify what exactly you are seeing? Like what platform are you testing on? Show me what you did?

To give an update - the rate limiting issue should be fixed now. But we might have CSP issues to look into on web since we are loading images and content that are outside our domain.

@melvin-bot melvin-bot bot removed the Overdue label Jul 15, 2023
@MonilBhavsar
Copy link
Contributor

MonilBhavsar commented Jul 18, 2023

Sorry, I mean link preview for other sites(except google) is seen. I tested right now on production and it worked!

Screenshot 2023-07-18 at 2 58 14 PM

@marcaaron
Copy link
Contributor

I think we can close this one out then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants