[HOLD for payment 2023-06-28] Font color is blue instead of white in mention

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. go to any chat
2. type @ and enter your mail

Expected Result:

blue font is not visible clearly with green background

Actual Result:

font color is blue

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.28-3
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-06-15.at.1.16.39.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686815472503979

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @youssef-lr (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[huzaifa-99]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We want the mention text to have a more visible color

What is the root cause of that problem?

In MentionUserRenderer we are passing a color prop, to TextLink which does accept a color prop.

What changes do you think we should make in order to solve the problem?

I think we don't have to apply white color, we should remove this line and update this line by adding StyleUtils.getMentionTextColor(isOurMention)

style={[_.omit(props.style, 'color'), StyleUtils.getMentionStyle(isOurMention),{color: StyleUtils.getMentionTextColor(isOurMention)}]}

Optional: We can merge StyleUtils.getMentionStyle and StyleUtils.getMentionTextColor methods to make a dry utility, we can also update StyleUtils.getMentionTextColor to return an object like {color: "color hex"} and update in other places

What alternative solutions did you explore? (Optional)

N/A

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Text color is not visible properly for the mention

What is the root cause of that problem?

Seems it is a regression from #19303, when Text is modified to TextLink but the color style we are not passing properly.

What changes do you think we should make in order to solve the problem?

We need to update the below part to pass color attribute with the style array and remove color prop line.

App/src/components/HTMLEngineProvider/HTMLRenderers/MentionUserRenderer.js

Lines 41 to 47 in d396430

	<TextLink
	// eslint-disable-next-line react/jsx-props-no-spreading
	{...defaultRendererProps}
	href={ROUTES.getDetailsRoute(loginWithoutLeadingAt)}
	color={StyleUtils.getMentionTextColor(isOurMention)}
	style={[_.omit(props.style, 'color'), StyleUtils.getMentionStyle(isOurMention)]}
	onPress={() => showUserDetails(loginWithoutLeadingAt)}

style={[props.style, {color: StyleUtils.getMentionTextColor(isOurMention)}, StyleUtils.getMentionStyle(isOurMention)]}

[marcaaron]

@puneetlath related to mentions feature (I think you said you would fix all of these somewhere )

[marcaaron]

Merged linked PR so this should be able to be checked off once it hits staging.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.28-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Wrong text color for our mention #20845

If no regressions arise, payment will be issued on 2023-06-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@youssef-lr] The PR that introduced the bug has been identified. Link to the PR:
• [@youssef-lr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@youssef-lr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@youssef-lr] Determine if we should create a regression test for this bug.
• [@youssef-lr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[luacmartins]

Fixed here - #20845

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.29-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Wrong text color for our mention #20845

If no regressions arise, payment will be issued on 2023-06-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@youssef-lr] The PR that introduced the bug has been identified. Link to the PR:
• [@youssef-lr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@youssef-lr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@youssef-lr] Determine if we should create a regression test for this bug.
• [@youssef-lr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[puneetlath]

@puneetlath related to mentions feature (I think you said you would fix all of these somewhere )

Yes I did! 😅 Feel free to assign me as CME on any mentions-related bugs in the future if you like!

[youssef-lr]

Not overdue.

[abekkala]

• Issue reported by: @gadhiyamanan [$250] - Upwork payment offer sent!

Fix was included in the PR above

[gadhiyamanan]

@abekkala accepted, thanks!

[abekkala]

Paid and contract ended - thank you! 🎉