Skip to content

[$1000] [HOLD for payment 2023-05-22] [Manual Requests] Update ReportScreen to display MoneyRequest Reports #18474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mountiny opened this issue May 5, 2023 · 22 comments
Closed

[$1000] [HOLD for payment 2023-05-22] [Manual Requests] Update ReportScreen to display MoneyRequest Reports #18474

mountiny opened this issue May 5, 2023 · 22 comments
Assignees
@Julesssss @trjExpensify @luacmartins @mollfpr @mountiny
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors NewFeature Something to build that is a new item.

Comments

@mountiny
Copy link
Contributor

mountiny commented May 5, 2023 •
edited by melvin-bot bot
Loading

Implement this internal section.

1 Reuse the ReportScreen component for this
2. Conditionally render MoneyRequestHeader here if ReportUtils.isMoneyRequestReport true, otherwise render HeaderView
3. The Expense/IOU reportActions should already be automatically passed to ReportActionsView
4. We’ll update ReportActionItemCreated to return early if ReportUtils.isMoneyRequestReport(reportID) is true so we don’t display the created header

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013db16ecb8981a4db
  • Upwork Job ID: 1661761420215586816
  • Last Price Increase: 2023-05-25
@mountiny mountiny added Engineering Daily KSv2 NewFeature Something to build that is a new item. labels May 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 5, 2023

Triggered auto assignment to @arielgreen (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels May 5, 2023
@mollfpr mollfpr mentioned this issue May 5, 2023
Closed
@mountiny
Copy link
Contributor Author

mountiny commented May 5, 2023

Slack thread for discussion is here

@mollfpr mollfpr mentioned this issue May 7, 2023
Merged
57 tasks
@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label May 7, 2023
@trjExpensify trjExpensify added Daily KSv2 and removed Weekly KSv2 labels May 8, 2023
@trjExpensify
Copy link
Contributor

Moving this back to daily, as it's a deliverable for EC3 next week. We need to stick to making daily progress if we're going to get the PR merged early this week. @mollfpr can you give us an ETA on the draft PR going into full review? Thanks!

@mollfpr
Copy link
Contributor

mollfpr commented May 9, 2023

@trjExpensify It should be ready within an hour, I'm completing the checklist and the screenshot test now.

@JmillsExpensify
Copy link

Woo! Nice work on this one.

@trjExpensify
Copy link
Contributor

Yeah, thanks for the urgency on this one @mollfpr. Much appreciated!

@arielgreen arielgreen removed their assignment May 10, 2023
@trjExpensify trjExpensify self-assigned this May 10, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels May 15, 2023
@melvin-bot melvin-bot bot changed the title [Manual Requests] Update ReportScreen to display MoneyRequest Reports [HOLD for payment 2023-05-22] [Manual Requests] Update ReportScreen to display MoneyRequest Reports May 15, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 15, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 15, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@trjExpensify trjExpensify added the External Added to denote the issue can be worked on by a contributor label May 25, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-05-22] [Manual Requests] Update ReportScreen to display MoneyRequest Reports [$1000] [HOLD for payment 2023-05-22] [Manual Requests] Update ReportScreen to display MoneyRequest Reports May 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 25, 2023

Job added to Upwork: https://www.upwork.com/jobs/~013db16ecb8981a4db

@melvin-bot
Copy link

melvin-bot bot commented May 25, 2023

Current assignee @trjExpensify is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented May 25, 2023

Current assignee @mollfpr is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 25, 2023

Current assignees @Julesssss, @mountiny, and @luacmartins are eligible for the External assigner, not assigning anyone new.

@trjExpensify trjExpensify added Bug Something is broken. Auto assigns a BugZero manager. and removed Help Wanted Apply this label when an issue is open to proposals by contributors labels May 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 25, 2023

Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

@melvin-bot

This comment was marked as outdated.

Sign in to view
@trjExpensify
Copy link
Contributor

Create the job, Melvin. 😅

@trjExpensify trjExpensify added External Added to denote the issue can be worked on by a contributor and removed External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. labels May 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 25, 2023

Current assignee @trjExpensify is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented May 25, 2023

Current assignee @mollfpr is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 25, 2023

Current assignees @Julesssss, @mountiny, and @luacmartins are eligible for the External assigner, not assigning anyone new.

@trjExpensify trjExpensify added NewFeature Something to build that is a new item. and removed Bug Something is broken. Auto assigns a BugZero manager. labels May 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 25, 2023

Current assignee @trjExpensify is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels May 25, 2023
@trjExpensify
Copy link
Contributor

trjExpensify commented May 25, 2023 •
edited
Loading

Okay... so @mollfpr, I've sent you an offer for $1,500 on this job. No C+ payment due, reviewed internally for EC3.

@trjExpensify trjExpensify added Daily KSv2 and removed Weekly KSv2 labels May 25, 2023
@trjExpensify
Copy link
Contributor

Settled up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Julesssss Julesssss

@trjExpensify trjExpensify

@luacmartins luacmartins

@mollfpr mollfpr

@mountiny mountiny

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors NewFeature Something to build that is a new item.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@JmillsExpensify @Julesssss @trjExpensify @luacmartins @mollfpr @mountiny @arielgreen @0xmiros