[HOLD for payment 2023-05-22] [$1000] LHN - Duplicate chats after Request/Send money red dot error testing

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

Prepare two users without messaging history

1. In the main testing device - Disable the internet connection
2. As the secondary user - Start a conversation with the user from the main testing device, send some messages
3. In the main testing device - click on the global create + Request money
4. Follow the prompts send IOU to the secondary user
5. Verify the IOU Preview and message appear greyed out
6. Enable the internet connection in the main testing
7. Verify you see a solid red dot on the chat row of the report that failed to create
8. Click/tap the X to dismiss the error message

Expected Result:

Verify the chat is removed from the LHN

Actual Result:

Red dots disappeared by themselves, duplicate split bill group chats are present in the LHN

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.83.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/3251680

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5976711_Send_Money_Elsewhere_-_Error_Test.mp4

Bug5976711_Split_bill_scneario.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a7b820d8bd03c165
• Upwork Job ID: 1637876841424584704
• Last Price Increase: 2023-03-22

[MelvinBot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[trjExpensify]

Oh wow, @mountiny this looks pretty broken. 😕 The chat should have been deleted after clearing the red brick road.

[mountiny]

Ooof yeah I think we still have something weird going on with the IOU flow, nobody got to fix this once Andre left I believe.

[trjExpensify]

Okay, so this is going to be internal related to the API right?

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01a7b820d8bd03c165

[MelvinBot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mananjadhav (Internal)

[trjExpensify]

Hm, why didn't this assign an internal engineer?

[MelvinBot]

Current assignee @mananjadhav is eligible for the Internal assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[neil-marcellini]

I would like to work on this but I have one too many daily issues right now so I'll send it to someone else so that I don't slow things down.

[melvin-bot]

@mananjadhav, @yuwenmemon, @trjExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[trjExpensify]

Waiting on a prod deploy, chill.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.13-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Simplify failure data for request/send money and make it more consistent with SplitBill #18328

If no regressions arise, payment will be issued on 2023-05-22. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mananjadhav]

@yuwenmemon @trjExpensify I am unable to trace the offending PR, and because it is likely we added fixes from the API too, do we know if this was an App only bug resulted from a previous PR?

Also while this is an edge case, I think we can add a regression test? wdyt? In my opinion, the Test Steps in the PR are good enough for the regression test.

[yuwenmemon]

Sounds great

[luacmartins]

Re-adding Bug label to assign a new BZ since @trjExpensify is ooo.

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[luacmartins]

@michaelhaxhiu just re-added the Bug label since @trjExpensify is ooo and the payment is overdue. Could you please help with that?

[trjExpensify]

I'm back, we can take Hax off this. Processing now.

[trjExpensify]

Also while this is an edge case, I think we can add a regression test? wdyt? In my opinion, the Test Steps in the PR are good enough for the regression test.

Applause caught this bug through executing the regression tests, so I don't think we need to add anything new for this.

@mananjadhav I've sent you an offer for $1000 here.

[michaelhaxhiu]

Sorry I didn't get to this yesterday :( tag me in today if you need on any other GHs (I know you had fulls hands at EC3 the past week @trjExpensify)

[mananjadhav]

Accepted @trjExpensify

[trjExpensify]

Perfect, settled up!