Skip to content

iOS Design improvements #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AndrewGable opened this issue Aug 14, 2020 · 2 comments · Fixed by #217
Closed

iOS Design improvements #152

AndrewGable opened this issue Aug 14, 2020 · 2 comments · Fixed by #217
Milestone
All Hand's Launch

Comments

@AndrewGable
Copy link
Contributor

cc @shawnborton

  1. Limit report title to two lines
  2. Give the last comment a bit of padding

Screen Shot 2020-08-14 at 10 28 28 AM
@AndrewGable AndrewGable added this to the Beta Launch milestone Aug 14, 2020
@quinthar quinthar removed this from the Beta Launch milestone Aug 15, 2020
@quinthar quinthar added LOW and removed MEDIUM labels Aug 15, 2020
@shawnborton
Copy link
Contributor

Hmm, it's weird that the last item doesn't have the padding below it like web does. Do you think the useSafeInset thing is pushing the input up and covering the bottom padding? Either way, I can have a looksie.

@quinthar quinthar added this to the All Hand's Launch milestone Aug 15, 2020
@AndrewGable AndrewGable mentioned this issue Aug 16, 2020
Merged
@shawnborton
Copy link
Contributor

I think you fixed the two-line thing in your hamburger PR, and I addressed the last padding thing here: #217

@shawnborton shawnborton mentioned this issue Aug 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
All Hand's Launch
Development

Successfully merging a pull request may close this issue.

Fix bottom padding on scrollview Expensify/App
3 participants
@quinthar @shawnborton @AndrewGable