Skip to content

LHN- "You don't have access to this chat" message is not displayed after change the URL to http://staging.new.expensify.com/r/hello #11536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kbecciv opened this issue Oct 3, 2022 · 9 comments
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Oct 3, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue found when executing PR #10452

Action Performed:

  1. Go to staging.new.expensify.com
  2. Log in with your account
  3. Navigate to a report url with an invalidID like http://staging.new.expensify.com/r/hello, check you see the You don't have access to this chat message

Expected Result:

User can see the "You don't have access to this chat" message after navigate to a report url with an invalidID like http://staging.new.expensify.com/r/hello

Actual Result:

"You don't have access to this chat" message is not displayed after change the URL to http://staging.new.expensify.com/r/hello

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.2.11.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20221003-104143_Chrome.1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Oct 3, 2022

Triggered auto assignment to @yuwenmemon (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@kbecciv kbecciv changed the title mWeb - LHN- "You don't have access to this chat" message is not displayed after change the URL to http://staging.new.expensify.com/r/hello LHN- "You don't have access to this chat" message is not displayed after change the URL to http://staging.new.expensify.com/r/hello Oct 3, 2022
@melvin-bot melvin-bot bot added the Overdue label Oct 6, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 7, 2022

@yuwenmemon Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot
Copy link

melvin-bot bot commented Oct 11, 2022

@yuwenmemon Still overdue 6 days?! Let's take care of this!

@yuwenmemon
Copy link
Contributor

Ah, this seems similar to the drawer closing thing that @marcaaron and @luacmartins were talking about here

@melvin-bot melvin-bot bot removed the Overdue label Oct 12, 2022
@yuwenmemon
Copy link
Contributor

And then later identified by @chiragsalian here as well

@yuwenmemon
Copy link
Contributor

@chiragsalian based on the above am I correct in thinking that this issue is to be handled as a part of the Comment Linking solution?

@chiragsalian
Copy link
Contributor

chiragsalian commented Oct 12, 2022

Ah yup the issue here is that closing the drawer on a reportID or reportActionID doesn't work currently and yes this will be tackled in comment linking. I'd say to just close this issue since its a known problem which will be tackled in comment linking.

@kbecciv
Copy link
Author

kbecciv commented Nov 23, 2022

QA team is having problem with it on build 1.2.30.0

Record_2022-11-23-10-21-39.mp4

@chiragsalian
Copy link
Contributor

well r/1234 does not sound like a valid reportID so routing to the LHN actually looks good to me 😅

And if you do enter a valid reportID, the drawer will still close so yes it's a valid problem but it's something that will be tackled in the comment linking issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants