[HOLD for payment 2022-11-16] [$500] Android/iOS - Workspace - Numbers shaking while updating rate in reimburse expenses @gadhiyamanan

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Launch the app
2. Log in with any account with Workspace or create one
3. Go Workspace > Reimburse expenses
4. Edit rate

Expected Result:

Numbers should not shake

Actual Result:

Numbers shaking while updating rate in reimburse expenses

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Android
• iOS

Version Number: 1.2.7.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20220907_225406_New.Expensify.mp4

LUTA9874.1.MP4

Expensify/Expensify Issue URL:

Issue reported by: @gadhiyamanan

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1662571711808209

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @flaviadefaria (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[melvin-bot]

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[AndrewGable]

Hmm, I don't think this is a bug and is intended behavior? The number can only be so big, so we remove the last number. Feel free to reply if you disagree.

[gadhiyamanan]

@AndrewGable i think we should add character limitations instead of removing last number

[AndrewGable]

Can you provide an example of this elsewhere in the app? Thanks!

[gadhiyamanan]

@AndrewGable please check send money, user can enter 8 character
https://user-images.githubusercontent.com/54790231/193086346-4573661c-0abb-42f3-897d-371a56755a7d.mp4

[AndrewGable]

Ok thank you, I agree let's match that functionality. I will send to external if you'd like to propose a solution.

[melvin-bot]

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[melvin-bot]

Current assignee @AndrewGable is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

@puneetlath, @AndrewGable, @thesahindia Whoops! This issue is 2 days overdue. Let's get this updated quick!

[sketchydroide]

This is a duplicated GH but on iOS, This makes me think this is not Android specific. Changing the Details, but Closing the other one.

[melvin-bot]

📣 @aimane-chnaif You have been assigned to this job by @AndrewGable!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[AndrewGable]

PR is under review, discussing

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist will need to be completed before the issue can be closed:

• A regression test has been added or updated so that the same bug will not reach production again. Link to the updated test here:
• The PR that introduced the bug has been identified. Link to the PR: Localize decimal separator #9800
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Localize decimal separator #9800 (comment)
• A discussion in #contributor-plus has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• Payment has been made to the issue reporter (if applicable)
• Payment has been made to the contributor that fixed the issue (if applicable)
• Payment has been made to the contributor+ that helped on the issue (if applicable)

[puneetlath]

@thesahindia could you help with identifying the PR where the bug was introduced?

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.25-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• debounce rate input in reimburse expenses #11967

If no regressions arise, payment will be issued on 2022-11-16. 🎊

[thesahindia]

@thesahindia could you help with identifying the PR where the bug was introduced?

I think #9800

[puneetlath]

@gadhiyamanan @aimane-chnaif @thesahindia can you please apply to the Upwork job here so I can get everyone paid out: https://www.upwork.com/jobs/~01427aa8632545994e

[gadhiyamanan]

Applied 🚀

[thesahindia]

Applied, thanks!

[aimane-chnaif]

@gadhiyamanan @aimane-chnaif @thesahindia can you please apply to the Upwork job here so I can get everyone paid out: https://www.upwork.com/jobs/~01427aa8632545994e

@puneetlath already applied. thanks!

[puneetlath]

Sorry for the delay! Sent you all hiring offers.

[melvin-bot]

@puneetlath, @AndrewGable, @thesahindia, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@puneetlath, @AndrewGable, @thesahindia, @aimane-chnaif Eep! 4 days overdue now. Issues have feelings too...

[thesahindia]

@puneetlath, let's close this. I believe it is settled.