Skip to content

[$250] Need a C+ review for https://github.com/Expensify/App/pull/10452 #11067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iwiznia opened this issue Sep 16, 2022 · 18 comments
Closed
Assignees
Labels

Comments

@iwiznia
Copy link
Contributor

iwiznia commented Sep 16, 2022

Creating this issue to trigger auto assigner for a review on #10452

@melvin-bot
Copy link

melvin-bot bot commented Sep 16, 2022

Triggered auto assignment to @kevinksullivan for Upwork job creation (chore: ContributorPlusReview), see https://stackoverflow.com/c/expensify/questions/13732 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Sep 16, 2022

Triggered auto assignment to @jliexpensify for Upwork job creation (chore: ContributorPlusReview), see https://stackoverflow.com/c/expensify/questions/13732 for more details.

@iwiznia
Copy link
Contributor Author

iwiznia commented Sep 16, 2022

Ohhh, a CM needs to create an issue. Thought the assigner was not working properly, sorry about that double assignment.

@jliexpensify
Copy link
Contributor

@melvin-bot
Copy link

melvin-bot bot commented Sep 17, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (Exported)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 17, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 17, 2022

Triggered auto assignment to @pecanoro (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot changed the title Need a C+ review for https://github.com/Expensify/App/pull/10452 [$250] Need a C+ review for https://github.com/Expensify/App/pull/10452 Sep 17, 2022
@jliexpensify jliexpensify removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 17, 2022
@jliexpensify
Copy link
Contributor

Hired @Santhosh-Sellavel

@pecanoro
Copy link
Contributor

@iwiznia I am not completely sure what we need to do here. I got assigned but I have no clue if you are looking for a CME or C+ to review the PR.

@iwiznia
Copy link
Contributor Author

iwiznia commented Sep 20, 2022

Sorry, that was the auto assigner, you are not needed here @pecanoro

@melvin-bot melvin-bot bot removed the Overdue label Sep 30, 2022
@Santhosh-Sellavel
Copy link
Collaborator

@iwiznia @jliexpensify

Can we keep this open until payment is issued?

@jliexpensify jliexpensify reopened this Oct 2, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 3, 2022

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot
Copy link

melvin-bot bot commented Oct 3, 2022

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@jliexpensify
Copy link
Contributor

According to @luacmartins - it looks like there wasn't actually an issue in #11503? So we're not reducing @Santhosh-Sellavel 's pay here right?

@luacmartins
Copy link
Contributor

@jliexpensify that's correct!

@jliexpensify
Copy link
Contributor

Not overdue.

@Santhosh-Sellavel
Copy link
Collaborator

@jliexpensify This is due for payment, and deployed to production 12 days ago!

@jliexpensify
Copy link
Contributor

@Santhosh-Sellavel apologies, just looked at the other issue. Paying now.

@jliexpensify
Copy link
Contributor

Paid, job closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants