Skip to content

[$1000] [Bug] IOS - Chat - Password - Save button bounces when moving from one line to another #11057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kbecciv opened this issue Sep 16, 2022 · 22 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@kbecciv
Copy link

kbecciv commented Sep 16, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Launch the app
  2. Log in any account
  3. Navigate to settings by clicking on the user avatar over LHN
  4. Click on change password
  5. Switch from one field to another

Expected Result:

The button should not twitch when switching from one field to another

Actual Result:

Save button bounces when moving from one line to another

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.2.1.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5734714_1609_button_Save.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Testing

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Sep 16, 2022

Triggered auto assignment to @dangrous (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@dangrous
Copy link
Contributor

Seems like something easy for external work. However I'm pretty sure it's due to the keyboard issues that we're handling internally (the place it jumps to/from is where, on my phone, autofill suggestions are shown, and so I think the jump is the phone registering it as a password blank and seeing if it has anything to fill it with - that's not showing in the attached video here but it's the exact place and so I think the keyboard just isn't showing up).

I'm going to move to weekly, and put a hold on it for the Keyboard Initiative.

@dangrous dangrous added Weekly KSv2 and removed Daily KSv2 labels Sep 16, 2022
@dangrous dangrous changed the title IOS - Chat - Password - Save button bounces when moving from one line to another [HOLD Keyboard Initiative] IOS - Chat - Password - Save button bounces when moving from one line to another Sep 16, 2022
@dangrous dangrous assigned dangrous and unassigned dangrous Sep 16, 2022
@JmillsExpensify JmillsExpensify changed the title [HOLD Keyboard Initiative] IOS - Chat - Password - Save button bounces when moving from one line to another [HOLD Keyboard Initiative] [Bug] IOS - Chat - Password - Save button bounces when moving from one line to another Sep 21, 2022
@JmillsExpensify JmillsExpensify changed the title [HOLD Keyboard Initiative] [Bug] IOS - Chat - Password - Save button bounces when moving from one line to another [HOLD #10273] [Bug] IOS - Chat - Password - Save button bounces when moving from one line to another Sep 27, 2022
@melvin-bot melvin-bot bot added the Overdue label Sep 27, 2022
@dangrous
Copy link
Contributor

This is on hold, not overdue

@dangrous
Copy link
Contributor

dangrous commented Oct 7, 2022

Holding for keyboard push

@melvin-bot melvin-bot bot removed the Overdue label Oct 7, 2022
@melvin-bot melvin-bot bot added the Overdue label Oct 17, 2022
@dangrous
Copy link
Contributor

Still on hold

@melvin-bot melvin-bot bot removed the Overdue label Oct 17, 2022
@puneetlath puneetlath added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 19, 2022
@melvin-bot melvin-bot bot added the Overdue label Oct 26, 2022
@dangrous
Copy link
Contributor

Still on hold

@melvin-bot melvin-bot bot removed the Overdue label Oct 26, 2022
@tgolen tgolen changed the title [HOLD #10273] [Bug] IOS - Chat - Password - Save button bounces when moving from one line to another [Bug] IOS - Chat - Password - Save button bounces when moving from one line to another Oct 31, 2022
@tgolen tgolen self-assigned this Oct 31, 2022
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Oct 31, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 31, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 31, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 31, 2022

Current assignees @tgolen and @dangrous are eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot changed the title [Bug] IOS - Chat - Password - Save button bounces when moving from one line to another [$250] [Bug] IOS - Chat - Password - Save button bounces when moving from one line to another Oct 31, 2022
@miljakljajic
Copy link
Contributor

Posted to Upwork.

@JmillsExpensify
Copy link

@miljakljajic Given that we're still early and no proposals have been accepted, I'm assigning myself per the new BZ process: https://stackoverflow.com/c/expensify/questions/14597/14598#14598.

@JmillsExpensify
Copy link

Contributors - this issue is still open and we're accepting proposals!

@JmillsExpensify
Copy link

Still waiting for proposals. Increasing the price to $500.

@JmillsExpensify JmillsExpensify changed the title [$250] [Bug] IOS - Chat - Password - Save button bounces when moving from one line to another [$500] [Bug] IOS - Chat - Password - Save button bounces when moving from one line to another Nov 8, 2022
@melvin-bot melvin-bot bot added the Overdue label Nov 11, 2022
@dangrous
Copy link
Contributor

Waiting for proposals.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 11, 2022
@dangrous
Copy link
Contributor

Still waiting for proposals.

@melvin-bot melvin-bot bot removed the Overdue label Nov 14, 2022
@JmillsExpensify
Copy link

We've hit another week with no proposals, so I'm raising the price to $1,000.

@JmillsExpensify JmillsExpensify changed the title [$500] [Bug] IOS - Chat - Password - Save button bounces when moving from one line to another [$1000] [Bug] IOS - Chat - Password - Save button bounces when moving from one line to another Nov 14, 2022
@bondydaa bondydaa self-assigned this Nov 15, 2022
@bondydaa bondydaa removed Help Wanted Apply this label when an issue is open to proposals by contributors External Added to denote the issue can be worked on by a contributor labels Nov 15, 2022
@bondydaa
Copy link
Contributor

will take a look into this today

@bondydaa
Copy link
Contributor

testing this on 1.2.27-4 on web, desktop and haven't been able to reproduce yet.

Tested on the following iOS devices and OS versions:
iOS 15.5 iPhone 13
iOS 15.5 iPhone SE

but couldn't reproduce either. Do we know if there was a specific iOS version that this didn't work on?

@tungmt
Copy link

tungmt commented Nov 16, 2022

I think it is iOS issue only. I can reproduce this issue with both iOS app/web (firefox) on all my devices:
iOS 16.1 iPhone 13 Pro
iOS 15.4.1 iPhone xs max
iOS 14.4.2 iPhone 6s

It is not happen in other platform when I tested it.

RPReplay_Final1668557730.MP4
RPReplay_Final1668557694.MP4
RPReplay_Final1668556508.MP4

@bondydaa
Copy link
Contributor

Spoke with @JmillsExpensify we're actually just going to close this. We are in the process of removing passwords all together from the platform so this view/page will be removed entirely sooner rather than later anyways.

@JmillsExpensify
Copy link

Yes, thank you so much @bondydaa for raising this. Apologies I missed this myself when taking over the issue. 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

9 participants