Skip to content

Web - Workspace- User receives error message in JS console when offline in General settings #10538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kavimuru opened this issue Aug 24, 2022 · 6 comments
Assignees

Comments

@kavimuru
Copy link

kavimuru commented Aug 24, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue found when executing #10432

Action Performed:

  1. Access staging.new.expensify.com
  2. Login and create a workspace
  3. Navigate to the initial Workspace settings page
  4. Go offline
  5. Open the General Settings page
  6. Verify the network tab in the JS console

Expected Result:

User expects no error messages in the JS Console

Actual Result:

User receives error messages

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web

Version Number: 1.1.89-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5702457_Error_in_console.mp4
Bug5702457_JS_Console_error_when_offline.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Aug 24, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Aug 24, 2022

Triggered auto assignment to @chiragsalian (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@cead22
Copy link
Contributor

cead22 commented Aug 24, 2022

This isn't a JS error message, this is only showing that we made an API call that failed (because we don't have a network connection)

It's possible that we may not have detected that the network connection wasn't working before we made the API call, but as far as I can tell after my first brief look there's no error here

@sketchydroide
Copy link
Contributor

yeah I would agree

@luacmartins
Copy link
Contributor

I agree and I think we should close the issue for the reason Carlos stated above

@cead22 cead22 removed the DeployBlockerCash This issue or pull request should block deployment label Aug 24, 2022
@cead22 cead22 assigned cead22 and unassigned chiragsalian Aug 24, 2022
@cead22
Copy link
Contributor

cead22 commented Aug 24, 2022

Thanks

@cead22 cead22 closed this as completed Aug 24, 2022
@cead22 cead22 removed the Hourly KSv2 label Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants